-
Notifications
You must be signed in to change notification settings - Fork 63
Improvement: Update timeouts in testsuite #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
10min are very generous here. It usually takes only a couple of secons.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2086 +/- ##
==========================================
+ Coverage 77.05% 77.35% +0.30%
==========================================
Files 112 113 +1
Lines 18959 19124 +165
==========================================
+ Hits 14608 14793 +185
+ Misses 4351 4331 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
|
Ahhhh we of course have to use the timeouts in our merge queue and not the pr checks... |
This reverts commit 4d202fc.
Improvement: Update timeouts in testsuite
| jobs: | ||
| t8code_cmake_tests: | ||
| timeout-minutes: 60 | ||
| timeout-minutes: 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the merge queue it needs 17:30 min
| timeout-minutes: 15 | |
| timeout-minutes: 25 |
| jobs: | ||
| t8code_cmake_tests: | ||
| timeout-minutes: 60 | ||
| timeout-minutes: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs 50 min in the merge queue
| timeout-minutes: 30 | |
| timeout-minutes: 70 |
| jobs: | ||
| t8code_cmake_tests: | ||
| timeout-minutes: 60 | ||
| timeout-minutes: 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs 17 min in the merge queue
| timeout-minutes: 15 | |
| timeout-minutes: 25 |
| runs-on: ubuntu-latest | ||
| container: dlramr/t8code-ubuntu:t8-dependencies | ||
| timeout-minutes: 90 | ||
| timeout-minutes: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs 1 min
| timeout-minutes: 10 | |
| timeout-minutes: 5 |
| runs-on: ubuntu-latest | ||
| container: dlramr/t8code-ubuntu:t8-dependencies | ||
| timeout-minutes: 90 | ||
| timeout-minutes: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 min
| timeout-minutes: 10 | |
| timeout-minutes: 15 |
| jobs: | ||
| t8code_cmake_tests: | ||
| timeout-minutes: 60 | ||
| timeout-minutes: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the merge queue it needs 17:30 min
| timeout-minutes: 30 | |
| timeout-minutes: 25 |
| jobs: | ||
| valgrind_check: | ||
| timeout-minutes: 95 | ||
| timeout-minutes: 70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs 69 minutes
| timeout-minutes: 70 | |
| timeout-minutes: 90 |
|
Taken from this merge queue run and this nightly run |
Closes #2087
After improving the runtime of our testsuite we have not updated the timeouts.
This PR sets appropiate timeouts for every workflow.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).