-
Notifications
You must be signed in to change notification settings - Fork 63
Improvement: Update release strategy #2094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the name was wrong
Prototyping is over
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2094 +/- ##
==========================================
+ Coverage 77.05% 77.35% +0.30%
==========================================
Files 112 113 +1
Lines 18959 19124 +165
==========================================
+ Hits 14608 14793 +185
+ Misses 4351 4331 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandro-elsweijer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This it again this type of review where we cannot really check if it works until it is merged and runs, right?
|
I like that you re-used the tarball job :) |
Thanks! It made things so much easier! |
Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
Actually, no! I have made it callable via a workflow dispatch. If you delete the the current monthly release, you trigger the workflow manually (if you use this branch) and check if it works. |
Closes #2095
Closes #2053
Make a proper tagged release and add a tarball of that version as an asset to the release.
An example can be found here: https://github.com/DLR-AMR/t8code/releases/tag/v4.0.0-26.01
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).