-
Notifications
You must be signed in to change notification settings - Fork 63
Improvement: Update gtest #2105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 237c5fb.
it is gtest_disable_mpi, so we have to use the opposite of our variable.
- use <BUILD_INTERFACE:...> to tell cmake to use these paths only during the build process, not when the project is installed or used by someone else
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2105 +/- ##
=======================================
Coverage 77.34% 77.35%
=======================================
Files 113 113
Lines 19099 19124 +25
=======================================
+ Hits 14772 14793 +21
- Misses 4327 4331 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| target_include_directories( T8 PRIVATE ${CMAKE_CURRENT_LIST_DIR} ) | ||
| target_include_directories( T8 PUBLIC | ||
| $<BUILD_INTERFACE:${CMAKE_BINARY_DIR}/src> | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still need it while configuring the fortran interace.
can be set on the dependency on the t8code_enable_mpi variable
Closes #2097
Removes the thirdparty folder and uses the FetchContent-Feature of Cmake.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).