Continuous #832

ldecicco-USGS · 2025-11-26T20:24:50Z

No description provided.

…nto continuous

ehinman · 2025-12-02T20:43:31Z

Hey there, I have time to review Wed/Thur.

ehinman · 2025-12-03T23:31:08Z

R/read_waterdata_continuous.R

+#' @export
+#' @param monitoring_location_id `r get_params("continuous")$monitoring_location_id`
+#' @param parameter_code `r get_params("continuous")$parameter_code`
+#' @param statistic_id `r get_params("continuous")$statistic_id`


Note to self to test: is this really a valid input? Isn't the stat id for continuous 00011?

I think it's a valid input, but only 00011 will return data. We could take it out of the argument list so hopefully it's less confusing? I'll double check there aren't some weird random other stat ids for continuous data.

R/walk_pages.R

tutorials/basic_slides_deck.qmd

vignettes/dataRetrieval.Rmd

Co-authored-by: Elise Hinman <121896266+ehinman@users.noreply.github.com>

ehinman · 2025-12-04T16:36:23Z

R/read_waterdata_continuous.R

+#' 
+#' @description `r get_description("continuous")`
+#' 
+#' Currently, the services only allow up to 3 years of data to be requested with


Is this a hard and fast rule?

Edit: asked Mike, got the answer. This is a helpful piece of info!

ehinman · 2025-12-04T16:57:27Z

This test produced a warning and the properties argument didn't work:

test = read_waterdata_continuous(
  monitoring_location_id = "USGS-01646500",
  time = "2024-01-01/2025-01-01",
  properties = c("time", "parameter_code", "time_series_id", "value", "unit_of_measure")
)

Requesting:
[https://api.waterdata.usgs.gov/ogcapi/v0/collections/continuous/items?f=json&lang=en-US&skipGeometry=TRUE&limit=50000&properties=time%2Cparameter_code%2Ctime_series_id%2Cvalue%2Cunit_of_measure&monitoring_location_id=USGS-01646500&time=2024-01-01%2F2025-01-01](vscode-file://vscode-app/Applications/Positron.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html#)
                                   
Warning message:
Unknown or uninitialised column: `monitoring_location_id`. 
Error in `order()`:
! argument 2 is not a vector
Show Traceback

It returns the requested data, just with all the columns.

ldecicco-USGS · 2025-12-04T17:02:36Z

Good catch, hard to order on a column that doesn't exist.

Co-authored-by: Elise Hinman <121896266+ehinman@users.noreply.github.com>

ehinman · 2025-12-04T19:46:42Z

vignettes/join_by_closest.Rmd

-knitr::kable(head(uv_trim))
-```

 Next we'll clean up the discrete water quality "qw" data to make it easy to follow in this tutorial. 


Do we need to keep using "qw" when its original source doesn't exist anymore? I kinda pre-date "qw" so find it kind of a weird abbreviation.

What's wrong with the quality of water measured at our gage?? 😂(I'll change it!)

ehinman · 2025-12-04T20:05:11Z

vignettes/read_waterdata_functions.Rmd

+Once the pipeline has completed, you can load the `ohio_discharge` data frame into your environment with `tar_load`:
+
+```{r eval=FALSE}
+tar_load(ohio_discharge)


SNAZZY. I just tested this out and it worked great.

ehinman · 2025-12-04T20:23:47Z

vignettes/tutorial.Rmd

+* USGS APIs (Water Data) 
 * Water Quality Portal (WQP)
-* USGS APIs (Water Data), which are new or in-development . 
+* National Water Information System (NWIS) - Legacy system that will eventually be retired.


Double-checking with Mike...but I believe I remember him saying that while Water Services is going away, the collective "NWIS" will still be a term used in this ecosystem. @mikemahoney218-usgs do I have that right?

The challenge specifically for dataRetrieval is that we called all of those functions (whether it was waterservices or waterdata) NWIS (readNWISxxx). I'll do a little effort to make it clear that NWIS Water Services are going to be retired - but for most dataRetrieval users, that distinction will not matter. We want to be clear that all the NWIS dataRetrieval functions will stop working eventually.

vignettes/tutorial.Rmd

Co-authored-by: Elise Hinman <121896266+ehinman@users.noreply.github.com>

ehinman

This looks good to me, @ldecicco-USGS. Thanks for the opportunity to review. Approved.

…nto continuous

ldecicco-USGS added 6 commits November 24, 2025 14:09

First pass

4d3ed55

missed again

2737c28

Merge branch 'develop' of https://code.usgs.gov/water/dataRetrieval i…

c26941d

…nto continuous

First pass

ce54d74

add note

9472c9b

Update docs

1df87c3

ldecicco-USGS temporarily deployed to CI_config November 26, 2025 20:24 — with GitHub Actions Inactive

pkgdown

aea1c58

ldecicco-USGS temporarily deployed to CI_config November 26, 2025 20:26 — with GitHub Actions Inactive

Limit bumped

b7825d2

ldecicco-USGS had a problem deploying to CI_config December 1, 2025 21:24 — with GitHub Actions Failure

Update tests

7a46151

ldecicco-USGS temporarily deployed to CI_config December 1, 2025 21:31 — with GitHub Actions Inactive

ldecicco-USGS requested a review from ehinman December 1, 2025 21:37

No bbox for continuous

04b7e49

ldecicco-USGS temporarily deployed to CI_config December 2, 2025 17:26 — with GitHub Actions Inactive

ldecicco-USGS added 4 commits December 3, 2025 09:38

Update docs

c66862e

cleanup language

64bd04d

More wordsmithing.

6f676ca

Add a targets example

bed2283

ldecicco-USGS temporarily deployed to CI_config December 3, 2025 18:12 — with GitHub Actions Inactive

ldecicco-USGS added 2 commits December 3, 2025 12:44

don't evaluate targets stuff

57132a4

proper links

99186ce

ldecicco-USGS temporarily deployed to CI_config December 3, 2025 18:46 — with GitHub Actions Inactive

bad link

d636c59

ldecicco-USGS temporarily deployed to CI_config December 3, 2025 19:01 — with GitHub Actions Inactive

ehinman reviewed Dec 3, 2025

View reviewed changes

R/walk_pages.R Outdated Show resolved Hide resolved

ehinman reviewed Dec 3, 2025

View reviewed changes

tutorials/basic_slides_deck.qmd Outdated Show resolved Hide resolved

ehinman reviewed Dec 3, 2025

View reviewed changes

vignettes/dataRetrieval.Rmd Outdated Show resolved Hide resolved

Update R/walk_pages.R

85568c4

Co-authored-by: Elise Hinman <121896266+ehinman@users.noreply.github.com>

ldecicco-USGS temporarily deployed to CI_config December 4, 2025 14:25 — with GitHub Actions Inactive

Update vignettes/dataRetrieval.Rmd

ef26a2f

Co-authored-by: Elise Hinman <121896266+ehinman@users.noreply.github.com>

ldecicco-USGS temporarily deployed to CI_config December 4, 2025 14:25 — with GitHub Actions Inactive

ehinman reviewed Dec 4, 2025

View reviewed changes

Update tutorials/basic_slides_deck.qmd

bf6878f

Co-authored-by: Elise Hinman <121896266+ehinman@users.noreply.github.com>

ldecicco-USGS temporarily deployed to CI_config December 4, 2025 17:30 — with GitHub Actions Inactive

ldecicco-USGS added 2 commits December 4, 2025 13:05

Remove id columns from daily/continuous

ebf37f6

Push id's to the far right.

84c269e

ldecicco-USGS temporarily deployed to CI_config December 4, 2025 19:19 — with GitHub Actions Inactive

updated news

d28ed5e

ldecicco-USGS temporarily deployed to CI_config December 4, 2025 19:24 — with GitHub Actions Inactive

fixed daily_id select

10e4106

ldecicco-USGS temporarily deployed to CI_config December 4, 2025 19:28 — with GitHub Actions Inactive

ehinman reviewed Dec 4, 2025

View reviewed changes

Cleanup properties documentation

015f7f3

ehinman reviewed Dec 4, 2025

View reviewed changes

vignettes/tutorial.Rmd Outdated Show resolved Hide resolved

Update vignettes/tutorial.Rmd

f6912aa

Co-authored-by: Elise Hinman <121896266+ehinman@users.noreply.github.com>

ldecicco-USGS temporarily deployed to CI_config December 4, 2025 20:27 — with GitHub Actions Inactive

ehinman approved these changes Dec 4, 2025

View reviewed changes

ldecicco-USGS added 3 commits December 4, 2025 14:53

NWIS words

c3272e7

Merge branch 'continuous' of github.com:ldecicco-USGS/dataRetrieval i…

4bc21b6

…nto continuous

language

23f4f14

ldecicco-USGS temporarily deployed to CI_config December 4, 2025 20:55 — with GitHub Actions Inactive

ldecicco-USGS merged commit d8d252f into DOI-USGS:develop Dec 4, 2025
1 check passed

Continuous #832

Continuous #832

Uh oh!

Conversation

ldecicco-USGS commented Nov 26, 2025

Uh oh!

ehinman commented Dec 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ehinman commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldecicco-USGS commented Dec 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ehinman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ehinman commented Dec 4, 2025 •

edited

Loading