Open
Conversation
Member
Leila-U
commented
Apr 4, 2021
Leila-U
commented
- Create Error Handling for getBuildings, getAllEvents, updateEvent, addEvent, deleteEvent
- Add snackbars for 400 and 500 errors
|
Visit the preview URL for this PR (updated for commit bd1aa0e): https://utmap-c252d--pr113-issue-97-client-crud-r4kwrm7a.web.app (expires Sun, 11 Apr 2021 19:46:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
RiddleMeDoo
reviewed
Apr 5, 2021
|
|
||
| <Snackbar open={openSnackBar400} autoHideDuration={4000} onClose={handleCloseSnackBar400}> | ||
| <Alert elevation={6} variant="filled" onClose={handleCloseSnackBar400} severity="error"> | ||
| 400 ERROR: Missing values! Change Form. |
Member
There was a problem hiding this comment.
Can you change the error message for 400? It's confusing (I'm not sure what "Change form" means) and it's not accurate for 404 errors. Let's say one user deletes an event and another user tries to update the same event, which will trigger a 404 error. The message should be something relevant to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.