Skip to content

Conversation

@pzlakowski
Copy link

@pzlakowski pzlakowski commented Jan 14, 2026

References

Fixes TypeScript files in repository root directory are not covered by ESLint #3676

Description

Typescript files at root level was not included in angular.json to be linted.

Instructions for Reviewers

List of changes in this PR:

  • I have added .eslintignore to ignore cypress.config.ts
  • I have added config in angular.json to lint files at root level
  • I have used npm run lint-fix hence server.ts and startup-message.ts changes
  • I have moved eslint comment to disable rules at top of file in server.ts because rule simple-import-sort/imports did not move import/no-namespace correctly and then lint would fail
  • I have added CommonJS require rule to be disabled in server.ts

Steps to test this PR:

  1. Remove some semicolons in the following files:
    • src/test.ts
    • server.ts
    • startup-message.ts
  2. Execute npm run lint-fix and check the files again
    • all files should be corrected

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added code task 1 APPROVAL pull request only requires a single approval to merge port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Jan 14, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge code task port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

TypeScript files in repository root directory are not covered by ESLint

3 participants