Skip to content

Conversation

@Sondissimo
Copy link
Contributor

Description

The current Italian label is not entirely accurate. We can use this alternative wording to better align it with the English meaning.

Instructions for Reviewers

The pr is updating the old labels with new ones, from "Allarme di sistema" to "Messaggio di servizio"

Include guidance for how to test or review your PR.
In the system-wide alert, set italian language, all the instances of "Allarme di sistema" should now be "Messaggio di servizio"

Checklist

  • [x ] My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • [x ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x ] My PR passes ESLint validation using npm run lint
  • [x ] My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • [ x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [x ] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • [x ] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • [x ] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • [x ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [ x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x ] If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Jan 20, 2026
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Jan 20, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Sondissimo ! This looks good to me

@github-project-automation github-project-automation bot moved this to 👍 Reviewer Approved in DSpace 10.0 Release Jan 20, 2026
@tdonohue tdonohue added the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Jan 20, 2026
@tdonohue tdonohue added this to the 10.0 milestone Jan 20, 2026
@tdonohue tdonohue merged commit a9e8958 into DSpace:main Jan 20, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Jan 20, 2026
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants