Skip to content

Fix spacing in en.json5#5275

Merged
tdonohue merged 3 commits intoDSpace:mainfrom
dataquest-dev:fix/en-json-spacing
Mar 23, 2026
Merged

Fix spacing in en.json5#5275
tdonohue merged 3 commits intoDSpace:mainfrom
dataquest-dev:fix/en-json-spacing

Conversation

@Kasinhou
Copy link
Contributor

@Kasinhou Kasinhou commented Mar 11, 2026 •
edited
Loading

Description

Fix spacing issues in en.json5 translation file.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@Kasinhou
Upstream/EN language - fixing spaces (#1249)
050f6a2 
Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
@lgeggleston lgeggleston added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Mar 11, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Mar 11, 2026
@saschaszott saschaszott self-requested a review March 12, 2026 07:17
saschaszott
saschaszott previously approved these changes Mar 12, 2026
View reviewed changes
Copy link
Contributor

@saschaszott saschaszott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Kasinhou . This all seems reasonable to me. This PR is ready to be merged.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Mar 12, 2026
saschaszott
saschaszott reviewed Mar 12, 2026
View reviewed changes
src/assets/i18n/en.json5 Outdated
Copy link
Contributor

@saschaszott saschaszott Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kasinhou , could you please replace the two blanks after the first sentence by a single blank.

src/assets/i18n/en.json5 Outdated
Copy link
Contributor

@saschaszott saschaszott Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kasinhou , could you please remove the blanks atfer > and before </a>.

src/assets/i18n/en.json5 Outdated
Copy link
Contributor

@saschaszott saschaszott Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kasinhou , could you please remove the blanks atfer > and before </a>.

src/assets/i18n/en.json5 Outdated
Copy link
Contributor

@saschaszott saschaszott Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kasinhou , could you please remove the blanks atfer > and before </a>.

src/assets/i18n/en.json5 Outdated
Copy link
Contributor

@saschaszott saschaszott Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kasinhou , could you please remove the blanks atfer > and before </a>.

@saschaszott saschaszott self-requested a review March 12, 2026 07:34
@saschaszott saschaszott dismissed their stale review March 12, 2026 07:35

found several translations with spacing issues

@saschaszott saschaszott mentioned this pull request Mar 12, 2026
Merged
12 tasks
@Kasinhou
Copy link
Contributor Author

Kasinhou commented Mar 17, 2026

Thank you @saschaszott for the review. The suggestions have been implemented.

saschaszott
saschaszott reviewed Mar 18, 2026
View reviewed changes
src/assets/i18n/en.json5 Outdated
"error.validation.coarnotify.invalidfilter": "Invalid filter, try to select another service or none.",

"request-status-alert-box.accepted": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been taken in charge.",
"request-status-alert-box.accepted": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been taken in charge.",
Copy link
Contributor

@saschaszott saschaszott Mar 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustment, @Kasinhou . I would suggest that we do not use a space after <a> and before </a>, but instead output {{ serviceName }} directly. Could you please update this as well (in four translations)?

Copy link
Contributor Author

@Kasinhou Kasinhou Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschaszott, updated

saschaszott
saschaszott approved these changes Mar 18, 2026
View reviewed changes
Copy link
Contributor

@saschaszott saschaszott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kasinhou ! This PR is ready for merging.

@saschaszott
Copy link
Contributor

saschaszott commented Mar 18, 2026

@tdonohue , do we want to backport these changes to DSpace version 9?

@milanmajchrak milanmajchrak mentioned this pull request Mar 23, 2026
Open
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Mar 23, 2026
@tdonohue tdonohue merged commit ef3d4b7 into DSpace:main Mar 23, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Mar 23, 2026
@dspace-bot dspace-bot mentioned this pull request Mar 23, 2026
Merged
@dspace-bot
Copy link
Contributor

dspace-bot commented Mar 23, 2026

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Mar 23, 2026
@tdonohue tdonohue added this to the 10.0 milestone Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschaszott saschaszott saschaszott approved these changes

Assignees

@Kasinhou Kasinhou

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

DSpace 10.0 Release
Status: ✅ Done

Milestone

10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Kasinhou @saschaszott @dspace-bot @tdonohue @lgeggleston