[Port to dspace-8_x] Fix submission form's "serious" accessibility issues#5298
Open
AndreaBarbasso wants to merge 1 commit intoDSpace:dspace-8_xfrom
Open
[Port to dspace-8_x] Fix submission form's "serious" accessibility issues#5298AndreaBarbasso wants to merge 1 commit intoDSpace:dspace-8_xfrom
AndreaBarbasso wants to merge 1 commit intoDSpace:dspace-8_xfrom
Conversation
|
@AndreaBarbasso thank you for porting this! Just to note it looks like this is failing a couple of unit tests (something to do with 'NgbModal'). |
(cherry picked from commit 85f1dbc)
2411590 to
df3fb98
Compare
Contributor
Author
Thanks @lgeggleston for the heads-up! I managed to fix the failing test, everything should be good now. EDIT: nevermind, working on the failing e2e test now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Added a11y features for "serious" problems occurring in the submission form.
Instructions for Reviewers
List of changes in this PR:
To test/review the PR, check that the functionality of the submission form has not been altered, and that a11y tests now do not contain serious issues.
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.