Skip to content

#5636 - fixing i18n translation problem for date picker labels #5647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanasznagyzoltan wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −21
Open

#5636 - fixing i18n translation problem for date picker labels #5647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e5d4b9
QREPO-403 fixing i18n translation problem for date picker labels
kanasznagyzoltan May 11, 2026
feedb4f
QREPO-403 updating code using the help given in the PR comment
kanasznagyzoltan May 13, 2026
8fbaf66
QREPO-403 removing unnecessary keys from hu.json5
kanasznagyzoltan May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/shared/form/builder/ds-dynamic-form-ui/models/date-picker/date-picker.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
[(ngModel)]="initialYear"
[value]="year"
[invalid]="showErrorMessages"
[placeholder]="'form.date-picker.placeholder.year' | translate"
[placeholder]="'form.date-picker.placeholder.year'"
[widthClass]="'four-digits'"
(blur)="onBlur($event)"
(change)="onChange($event)"
Expand All @@ -35,7 +35,7 @@
[size]="2"
[(ngModel)]="initialMonth"
[value]="month"
[placeholder]="'form.date-picker.placeholder.month' | translate"
[placeholder]="'form.date-picker.placeholder.month'"
[disabled]="!year || model.disabled"
[widthClass]="'two-digits'"
(blur)="onBlur($event)"
Expand All @@ -52,7 +52,7 @@
[size]="2"
[(ngModel)]="initialDay"
[value]="day"
[placeholder]="'form.date-picker.placeholder.day' | translate"
[placeholder]="'form.date-picker.placeholder.day'"
[disabled]="!month || model.disabled"
[widthClass]="'two-digits'"
(blur)="onBlur($event)"
Expand Down
12 changes: 6 additions & 6 deletions src/app/shared/form/number-picker/number-picker.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<div class="d-flex flex-column align-items-center">
<label class="ml-n3" [for]="id">{{'form.number-picker.label.' + placeholder | translate }}</label>
<label class="ml-n3" [for]="id">{{placeholder | translate}}</label>
<div class="d-flex flex-column align-items-stretch justify-content-around position-relative">
<button id="increment-{{id}}"
class="btn btn-link-focus btn-date ml-2"
type="button"
tabindex="0"
[dsBtnDisabled]="disabled"
(click)="toggleUp()"
title="{{'form.number-picker.increment' | translate: {field: placeholder} }}"
[attr.aria-label]="'form.number-picker.increment' | translate: {field: placeholder}">
title="{{'form.number-picker.increment' | translate: {field: (placeholder | translate)} }}"
[attr.aria-label]="'form.number-picker.increment' | translate: {field: (placeholder | translate)}">
<span class="chevron"></span>
<span class="sr-only">{{'form.number-picker.increment' | translate: {field: name} }}</span>
</button>
Expand All @@ -26,7 +26,7 @@
[readonly]="disabled"
[disabled]="disabled"
[ngClass]="{'is-invalid': invalid}"
title="{{'form.number-picker.label.' + placeholder | translate}}"
title="{{placeholder | translate}}"
[attr.aria-labelledby]="id + ' increment-' + id + ' decrement-' + id"
>

Expand All @@ -36,8 +36,8 @@
tabindex="0"
[dsBtnDisabled]="disabled"
(click)="toggleDown()"
title="{{'form.number-picker.decrement' | translate: {field: placeholder} }}"
[attr.aria-label]="'form.number-picker.decrement' | translate: {field: placeholder}">
title="{{'form.number-picker.decrement' | translate: {field: (placeholder | translate)} }}"
[attr.aria-label]="'form.number-picker.decrement' | translate: {field: (placeholder | translate)}">
<span class="chevron bottom"></span>
<span class="sr-only">{{'form.number-picker.decrement' | translate: {field: name} }}</span>
</button>
Expand Down
12 changes: 0 additions & 12 deletions src/assets/i18n/hu.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3428,18 +3428,6 @@
// "form.number-picker.increment": "Increment {{field}}",
"form.number-picker.increment": "{{field}} növelése",

// "form.number-picker.label.Year": "Year",
// TODO New key - Add a translation
"form.number-picker.label.Year": "Year",

// "form.number-picker.label.Month": "Month",
// TODO New key - Add a translation
"form.number-picker.label.Month": "Month",

// "form.number-picker.label.Day": "Day",
// TODO New key - Add a translation
"form.number-picker.label.Day": "Day",

// "form.repeatable.sort.tip": "Drop the item in the new position",
"form.repeatable.sort.tip": "Húzza az elemet az új pozícióba.",

Expand Down
Loading