Fix for network splits and fabrication chests. #812
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private boolean isRecipeCraftable(Recipe<?> recipe, int index) { | ||
| // Don't check if a recipe can be crafted when simulating insertion of its remainders. | ||
| if(Transaction.isOpen()) { |
Contributor
There was a problem hiding this comment.
nit: for consistency, put a space between the if and condition here
also, the body is so small that it might as well not use curly braces (or even a new line, since it's overall small)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fabrication chests are currently partially nonfunctional for recipes that may have a remainder.