Open
Conversation
Contributor
Author
|
Instead of exiting the loop, when MAX_SEED is reached, one could raise an exception |
Contributor
Author
|
I'm sorry for the delay of my answer. |
Contributor
Author
|
As a polygon is 'closed', which means that even if the ray might be parallel to an edge, it will cross some other edges. Why do we need to test for ray not to be parallel to any edge ? |
Contributor
Author
|
In fact, this PR is more an idea to test another approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
You may find here a pull request removing the full randomness to determine a good_ray.
I've added missing test for closed polygons.
The test is based on the following gist :
https://gist.github.com/PikachuEXE/71c6d0961e6bdc31846f
Thanks to @PikachuEXE :-)