Skip to content

Makes indexes of stat lists a type rather then string#743

Merged
XeonMations merged 8 commits intoDarkPack13:masterfrom
FalloutFalcon:yet-another-stat-rework
Mar 16, 2026
Merged

Makes indexes of stat lists a type rather then string#743
XeonMations merged 8 commits intoDarkPack13:masterfrom
FalloutFalcon:yet-another-stat-rework

Conversation

@FalloutFalcon
Copy link
Copy Markdown
Member

@FalloutFalcon FalloutFalcon commented Mar 6, 2026

About The Pull Request

Makes indexes of stat holder lists a type rather then string

Why It's Good For The Game

The only place a string was useful was tgui so we do text2path there instead of EVERYWHERE else.

Allows for better handling, as you can access the type directly if you need something like a name, and dont have to wrap all logic on strings which is annoying.

Its a hanger-on from when we were direct saving the list for prefs. this is no longer needed.

Changelog

🆑
code: List index for stats was made its type instead of a type as a string
/:cl:

@FalloutFalcon FalloutFalcon requested a review from a team as a code owner March 6, 2026 06:34
@FalloutFalcon FalloutFalcon marked this pull request as draft March 6, 2026 06:39
@FalloutFalcon
Copy link
Copy Markdown
Member Author

FalloutFalcon commented Mar 6, 2026

Im realizing this seems to be a breaking change for pref. and i will prob want to write an update script for it.... No i think i missed a piece of code is all. why would this break when we still always store as a string. what would i write an update to even fix.
plus imma wait on #738

@github-actions
Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself.

@github-actions github-actions Bot added the Stale label Mar 14, 2026
@FalloutFalcon FalloutFalcon marked this pull request as ready for review March 15, 2026 17:18
@github-actions github-actions Bot removed the Stale label Mar 16, 2026
@XeonMations XeonMations added this pull request to the merge queue Mar 16, 2026
Merged via the queue into DarkPack13:master with commit 43e85bc Mar 16, 2026
22 checks passed
darkpack13-api Bot added a commit that referenced this pull request Mar 16, 2026
github-actions Bot added a commit that referenced this pull request Mar 16, 2026
@FalloutFalcon FalloutFalcon mentioned this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants