Added pption to force reliable ordering of TCP messages.#15
Open
Rich2020 wants to merge 1 commit intoDarkRiftNetworking:masterfrom
Open
Added pption to force reliable ordering of TCP messages.#15Rich2020 wants to merge 1 commit intoDarkRiftNetworking:masterfrom
Rich2020 wants to merge 1 commit intoDarkRiftNetworking:masterfrom
Conversation
- Added TcpOptions with property 'ForceReliableOrdering' to enable forced reliable ordering. - Modified TcpConnection BodyReadCallback to make use of ForceReliableOrdering.
Member
|
Hi Rich, Sorry about the delay in reviewing this, my internet's been intermittent the last week! The changes all look good but my only concern is that some people may prefer the property to be different between connections hence being better as a property of TcpConnection. Maybe new connections could be given the correct value based upon a value set in the listener? The change for the VSCode folder is absolutely fine! Jamie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jamie,
As discussed, I've made an option to toggle the forced reliability of TCP message ordering.
I've made changes to two files:
TcpOptionswith propertyForceReliableOrderingto enable forced reliable ordering.TcpConnection.BodyReadCallbackto make use ofForceReliableOrdering.I took a quick look, and it seems that the TcpOptions class is a clean way to go as we do not want to have to set forced order reliability twice (on connection and on
args.Connectionin theNewConnectioncallback).To use this, simply put
TcpOptions.ForceReliableOrdering = true;anywhere in your code and messages will arrive in the order in which they were sent. By default, this option is set tofalse.Please note that I had to add
.vs/to the bottom of the.gitignorefile as I was gettingsqllite.db locks... see: https://stackoverflow.com/a/48220209/596841Hope this change is acceptable and that it is helpful.
Kind regards,
Rich