You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Tinoxy Probably better to add it step by step instead of altogether:
create a branch
add some module or behavior
make pull request
wait for review and merge
go to step 1
About translations better to add prefix berti. (your folder name) to each one your translation key.
Also instead of duplicate many times .activated=Activated you can use general.enabled=Enable
And last one, the plugin.json and strings_en.properties need to update directly in the src/main/resources/
Exactly, apart from the fact that if you do it that way, I can't supervise each feature separately and I need to review them separately in case any of them don't comply with the rules.
My recommendation is that you first separate the features that interest you most.
The reason will be displayed to describe this comment to others. Learn more.
As already mentioned, a PR per functionality.
I would add that these features are those of another plugin that is still available. I don't see the point in adding the same features while the other plugin works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Optimoth