Skip to content

cpu/amd/pi: Use AMD common block for TSC#887

Merged
miczyg1 merged 1 commit into
dasharo-25.12from
cpu_amd_pi_tsc
May 15, 2026
Merged

cpu/amd/pi: Use AMD common block for TSC#887
miczyg1 merged 1 commit into
dasharo-25.12from
cpu_amd_pi_tsc

Conversation

@miczyg1
Copy link
Copy Markdown
Contributor

@miczyg1 miczyg1 commented May 13, 2026

Select options to utilize common AMD block for TSC. The coreboot timestamp table needs the tick frequency to be provided by TSC. Currently AMD PI CPU uses LAPIC as the timer, which does not provide the TSC tick frequency. It is also required to properly measure firmware performance in EDK2.

Upstream-Status: Pending

Copy link
Copy Markdown
Member

@SergiiDmytruk SergiiDmytruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes boot on APU and LGTM, but CI is mostly broken. Did SDK bump in 08f6a66 do this (error)?

@miczyg1
Copy link
Copy Markdown
Contributor Author

miczyg1 commented May 14, 2026

Fixes boot on APU and LGTM, but CI is mostly broken. Did SDK bump in 08f6a66 do this (error)?

Not sure how is this possible, because I have been using the new SDK without problems...

@miczyg1
Copy link
Copy Markdown
Contributor Author

miczyg1 commented May 14, 2026

Fixes boot on APU and LGTM, but CI is mostly broken. Did SDK bump in 08f6a66 do this (error)?

Not sure how is this possible, because I have been using the new SDK without problems...

Opened #888 with very verbose output to see what is going on

@miczyg1
Copy link
Copy Markdown
Contributor Author

miczyg1 commented May 14, 2026

@SergiiDmytruk seems I have found the culprit: #889
But still have no explanation why it has changed suddenly with newer containers. The raw coreboot-sdk containers showed the same behavior, so I think something in upstream has changed.

Select options to utilize common AMD block for TSC. The coreboot
timestamp table needs the tick frequency to be provided by TSC.
Currently AMD PI CPU uses LAPIC as the timer, which does not provide
the TSC tick frequency. It is also required to properly measure
firmware performance in EDK2.

Upstream-Status: Pending
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
@miczyg1 miczyg1 merged commit a182404 into dasharo-25.12 May 15, 2026
40 of 54 checks passed
@miczyg1 miczyg1 deleted the cpu_amd_pi_tsc branch May 15, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants