A bunch of bug fixes and feature improvements by petorikooru · Pull Request #12 · Daskom-Lab/daskomrec26

petorikooru · 2026-03-28T03:22:53Z

The information is available on the commit message

…ement + Added New Background Music

… announcement)

… who forgot the password

nice

…tant

IritaSee · 2026-03-29T07:26:53Z

@copilot ensure this PR is only for frontend improvements

Copilot

Pull request overview

This PR bundles multiple UI tweaks and admin-side improvements, including a new admin password-change flow, global audio mute control, and updated announcement/state handling, alongside dependency updates.

Changes:

Added admin routes + controller actions + UI for changing a user’s password via NIM search/autocomplete.
Introduced a global mute toggle (SoundProvider state + new MuteButton mounted in the app shell).
Refined announcement UX (scrolling/layout) and status handling (pending state), plus various UI/layout adjustments across user/admin pages.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
routes/web.php	Adds admin endpoints for password change UI + submit.
resources/js/app.jsx	Mounts the global `MuteButton` within `SoundProvider`.
resources/js/Pages/welcome.jsx	Adjusts landing page image positioning classes.
resources/js/Pages/User/oaline.jsx	Updates footer styling/content rendering.
resources/js/Pages/User/cores.jsx	Tweaks unlocked-all CTA positioning.
resources/js/Pages/User/assistants.jsx	Adjusts total page count and adds footer.
resources/js/Pages/User/announcement.jsx	Reworks layout to allow scrolling, fixes positioning, adds internal scroll area and scrollbar-hiding styles.
resources/js/Pages/Admin/password.jsx	Adds NIM autocomplete/search dropdown and UX updates for admin password changes.
resources/js/Pages/Admin/home.jsx	Switches displayed admin name to come from Inertia shared props.
resources/js/Pages/Admin/caas.jsx	Formatting-only JSX changes and minor router call cleanup.
resources/js/Components/UnderwaterEffect.jsx	Removes inline SVG filter defs and refactors whitespace/formatting.
resources/js/Components/SoundProvider.jsx	Adds mute state + exposes `muted` in context; lowers default volume.
resources/js/Components/ShiftSuccessModal.jsx	Removes desktop close button block (and previously removed backdrop click).
resources/js/Components/MuteButton.jsx	New fixed-position UI control to toggle mute via Sound context.
resources/js/Components/CaasCard.jsx	Adds truncation and max-width class for card text.
resources/js/Components/AssistantBook.jsx	Removes a comment line (no functional change).
resources/js/Components/AdminDashboard.jsx	Adjusts pending-action type handling, stage label mapping, and adds scroll/word-wrap helper CSS.
composer.lock	Updates Laravel/ecosystem dependencies and lock metadata.
app/Http/Controllers/UserController.php	Adds `passwordChangeView` + `updatePassword` endpoints and search logic.
app/Http/Controllers/User/AnnouncementController.php	Introduces `pending` status mapping using `match`.
README.md	Updates logo asset reference to `.webp` and minor formatting.

Comments suppressed due to low confidence (1)

resources/js/Components/UnderwaterEffect.jsx:103

backdropFilter/WebkitBackdropFilter references url(#waterDistortion), but the <svg><filter id="waterDistortion" ...></filter></svg> definition was removed from this component. As a result the distortion filter won’t resolve; either restore the SVG filter defs (e.g., hidden in the DOM) or remove the url(#waterDistortion) reference and rely on supported CSS effects.

                        zIndex: 3,
                        backdropFilter: 'url(#waterDistortion) blur(1px)',
                        WebkitBackdropFilter: 'url(#waterDistortion) blur(1px)',
                        background: 'rgba(0, 100, 200, 0.08)',
                        pointerEvents: 'none'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-29T07:34:40Z

resources/js/Pages/User/assistants.jsx

+                {/* Footer */}
+                <div className={`absolute bottom-4 w-full text-center z-40 pointer-events-none transition-opacity duration-1000 delay-500 ${isExiting || isLoggingOut ? "opacity-0" : "opacity-100"}`} >
+                    <p className="text-white font-caudex text-[10px] md:text-xl tracking-widest drop-shadow-md">
+                        @Atlantis.DLOR2026. All Right Served


Spelling: footer text should read “All Rights Reserved” (not “All Right Served”).

Suggested change

@Atlantis.DLOR2026. All Right Served

@Atlantis.DLOR2026. All Rights Reserved

@petorikooru is this intentional? (Easter Egg related?)

my bad, it is a typo

Copilot · 2026-03-29T07:34:41Z

resources/js/Pages/User/announcement.jsx

                                        )}

-                                        {/* If Revelaled */}
+{/* If Revelaled */}


Spelling: comment says “If Revelaled”; should be “If Revealed”.

Suggested change

{/* If Revelaled */}

{/* If Revealed */}

Copilot · 2026-03-29T07:34:41Z

app/Http/Controllers/UserController.php

+        $user = User::where('nim', $request->current_password)->firstOrFail();
+
+        $user->update([


This endpoint validates current_password against users.nim and then updates that user’s password, which effectively allows changing any account’s password by NIM (including admins). If that’s not intended, restrict the query/validation to non-admin users and/or add an authorization check for which accounts an admin can modify.

Suggested change

$user = User::where('nim', $request->current_password)->firstOrFail();

$user->update([

$authenticatedUser = $request->user();

if (!$authenticatedUser || $authenticatedUser->nim !== $request->current_password) {

return back()->withErrors([

'current_password' => 'The provided NIM does not match the authenticated user.',

]);

}

$authenticatedUser->update([

Copilot · 2026-03-29T07:34:41Z

resources/js/Pages/Admin/password.jsx

    const backgroundRef = useRef(null);
-    const [showImage, setShowImage] = useState(false);
+    const searchTimeoutRef = useRef(null);



searchTimeoutRef is used to debounce the search, but the pending timeout isn’t cleared on unmount. Add a cleanup (e.g., in a useEffect return) to clearTimeout(searchTimeoutRef.current) to avoid a delayed router.get firing after navigation.

Suggested change

useEffect(() => {

return () => {

if (searchTimeoutRef.current) {

clearTimeout(searchTimeoutRef.current);

}

};

}, []);

@petorikooru i think we can skip this but this might raise a new bug in the future, kindly check them out

i see, i will investigate it later

Copilot · 2026-03-29T07:34:41Z

resources/js/Pages/User/cores.jsx

                {/* Unlocked ALL */}
                {allUnlocked && !isMapPlacing && !isExiting && !isLoggingOut && (
-                    <div className="absolute bottom-20 md:bottom-24 w-full flex justify-center z-50 transition-opacity duration-1000 animate-fadeIn">
+                    <div className="absolute bottom-30 md:bottom-24 w-full flex justify-center z-50 transition-opacity duration-1000 animate-fadeIn">


bottom-30 isn’t part of Tailwind’s default spacing scale, and this project’s @theme section doesn’t define custom spacing tokens. If this class isn’t generated, the element will fall back to bottom: auto. Use a valid spacing utility (e.g., bottom-28/bottom-32) or an arbitrary value like bottom-[7.5rem].

Suggested change

<div className="absolute bottom-30 md:bottom-24 w-full flex justify-center z-50 transition-opacity duration-1000 animate-fadeIn">

<div className="absolute bottom-[7.5rem] md:bottom-24 w-full flex justify-center z-50 transition-opacity duration-1000 animate-fadeIn">

Copilot · 2026-03-29T07:34:42Z

resources/js/Pages/User/oaline.jsx

-                    <p>@Atlantis.DLOR2026. All Right Served</p>
+                <div className={`absolute bottom-4 w-full text-center z-40 pointer-events-none transition-opacity duration-1000 delay-500 ${isExiting || isLoggingOut ? "opacity-0" : "opacity-100"}`} >
+                    <p className="text-[#a9bcca] font-caudex text-[10px] md:text-xl tracking-widest drop-shadow-md">
+                        @Atlantis.DLOR2026. All Right Served


Spelling: footer text should read “All Rights Reserved” (not “All Right Served”).

Suggested change

@Atlantis.DLOR2026. All Right Served

@Atlantis.DLOR2026. All Rights Reserved

@petorikooru is this intentional?

My bad, that's a typo

Copilot · 2026-03-29T07:34:42Z

resources/js/Pages/Admin/home.jsx

+    const {auth} = usePage().props;
+    const profile= auth.profile|| {};
+
+    const USER = profile.name || "Admin";


auth shared by HandleInertiaRequests exposes auth.user, not auth.profile, so auth.profile will be undefined and the UI will always fall back to “Admin”. Use auth.user (and auth.user.profile if it’s loaded) or update the shared props to include profile/eager-load the relation.

Suggested change

const {auth} = usePage().props;

const profile= auth.profile|| {};

const USER = profile.name || "Admin";

const { auth } = usePage().props;

const user = auth?.user || {};

const profile = user.profile || {};

const USER = profile.name || user.name || "Admin";

Copilot · 2026-03-29T07:34:42Z

resources/js/Components/ShiftSuccessModal.jsx

                                </div>
                            </div>
                        </div>
-
-                        <div className="absolute bottom-16 w-full flex justify-center">
-                             <button onClick={onClose} className="text-white/50 text-sm hover:text-white transition-colors">Close</button>
-                        </div>
                    </div>
-
                </div>
            </div>
        </div>


The desktop layout no longer has any close affordance (the backdrop click handler is commented out and the desktop “Close” button was removed). This can trap desktop users in the modal; add a close button to the desktop layout and/or re-enable a safe dismiss mechanism (e.g., ESC key and/or backdrop click).

this is intentional since the user can no longer reselect the shift

Copilot · 2026-03-29T07:34:43Z

app/Http/Controllers/UserController.php

+        if ($search) {
+            $users = User::with('profile')
+                ->where('nim', 'like', "%{$search}%")
+                ->orWhereHas('profile', function ($q) use ($search) {
+                    $q->where('name', 'like', "%{$search}%");


The search query can return admin accounts too (no is_admin = false filter). Since this page is for changing practikans/CaAs passwords, consider explicitly restricting results to non-admin users (and ideally only eligible roles) to avoid accidentally exposing/changing admin credentials.

Copilot · 2026-03-29T07:34:43Z

resources/js/Pages/Admin/password.jsx

+    // CaAs Search Handler
+    const handleSearch = (value) => {
+        setData("current_password", value);
+
+        if (searchTimeoutRef.current) clearTimeout(searchTimeoutRef.current);
+
+        searchTimeoutRef.current = setTimeout(() => {
+            router.get(
+                window.location.pathname, // Keeps the request on the current page
+                { search: value },
+                { preserveState: true, replace: true }
+            );
+        }, 300);


The form field named current_password is being repurposed as “Praktikans NIM” (and is also used as the live search term). This is confusing and makes validation/errors harder to reason about; consider renaming the field to nim (and keeping search as separate UI state/query param) in both the React form and the controller validation.

…admin only

… view on mobile screen

…ance on firefox based browser)

… MuteButton components on AdminSidebar + Username fix on Admin homepage + slightly tweak the password setting from the recommendation from claude bot

petorikooru and others added 17 commits February 18, 2026 23:41

Minor Refactor on File Naming and Stuff + Additional UI and UX improv…

8514ead

…ement + Added New Background Music

Remove svg filter for performance reason (it kinda useless though)

5f14845

Added mute button

1b3a4a5

Updated the assistant list

c8ffed2

Updated the README.md image linking

b578b47

Set the default admin name to "Admin"

b2517e7

Fix typo on the home admin

e10ec79

Adjust the url to the true naming

5e00129

Fixed the text wrapping on the description area

3e28e35

Add changes

45391a2

Merge branch 'main' of https://github.com/kaylaperanginangin/daskomrec26

37f0b1c

Add explicit "Process" stage (in case someone accidentally reopen the…

e86d969

… announcement)

Moved the button a bit up

39f3724

Removed the close button (we forgot 💀)

2fd4bd0

Merge branch 'petorikooru:main' into main

07f0bb5

Added a change password page in admin specifically for the praktikans…

1125d20

… who forgot the password

Merge branch 'petorikooru:main' into main

d9f85ca

petorikooru requested review from Alizaaaja4, IritaSee, Soedipo, adhiiimf, fakhrip, marzkigun27 and vincentiusantu March 28, 2026 03:22

kaylaperanginangin and others added 6 commits March 28, 2026 12:36

Add change announcement page

536f477

Update Admin prewiew announcement text

d7a8f3d

deleted image png and song mp3

9d9afb6

deleted file

acac7c0

Merge pull request #14 from kaylaperanginangin/main

0029018

nice

Merge branch 'main' into main

2311ef4

petorikooru requested a review from ShowMeMyCent March 28, 2026 10:50

petorikooru added 2 commits March 29, 2026 14:19

Revert the changes on the img url since we add new 2 easter egg assis…

a5d9ec2

…tant

Adjust the footer size to match with others

8437c0b

IritaSee requested a review from Copilot March 29, 2026 07:28

Copilot started reviewing on behalf of IritaSee March 29, 2026 07:28 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

petorikooru added 7 commits March 30, 2026 22:09

Making sure that the change password for all user only available for …

e661adc

…admin only

Fix typos on the footer text

dceea51

Moved the mute button to sidebar instead so that it wont obstruct the…

7bebb9e

… view on mobile screen

Pre-process the image instead of adding filter (improving the perform…

7d7ef1e

…ance on firefox based browser)

Tweaked the animation on Card and Assistant Book + fix the typos

15e0255

Fix the text overflow on configuration editor preview + forgot to add…

ebf186a

… MuteButton components on AdminSidebar + Username fix on Admin homepage + slightly tweak the password setting from the recommendation from claude bot

Remove unnecessary classes

049e22a

	@Atlantis.DLOR2026. All Right Served
	@Atlantis.DLOR2026. All Rights Reserved

		$user = User::where('nim', $request->current_password)->firstOrFail();

		$user->update([

-        $user = User::where('nim', $request->current_password)->firstOrFail();
-        $user->update([
+        $authenticatedUser = $request->user();
+        if (!$authenticatedUser || $authenticatedUser->nim !== $request->current_password) {
+            return back()->withErrors([
+                'current_password' => 'The provided NIM does not match the authenticated user.',
+            ]);
+        }
+        $authenticatedUser->update([

+    useEffect(() => {
+        return () => {
+            if (searchTimeoutRef.current) {
+                clearTimeout(searchTimeoutRef.current);
+            }
+        };
+    }, []);

	<div className="absolute bottom-30 md:bottom-24 w-full flex justify-center z-50 transition-opacity duration-1000 animate-fadeIn">
	<div className="absolute bottom-[7.5rem] md:bottom-24 w-full flex justify-center z-50 transition-opacity duration-1000 animate-fadeIn">

-    const {auth} = usePage().props;
-    const profile= auth.profile|| {};
-    const USER = profile.name || "Admin";
+    const { auth } = usePage().props;
+    const user = auth?.user || {};
+    const profile = user.profile || {};
+    const USER = profile.name || user.name || "Admin";

Conversation

petorikooru commented Mar 28, 2026

Uh oh!

IritaSee commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants