♻️ move long task contexts to profiler#4046
Draft
BenoitZugmeyer wants to merge 2 commits intomainfrom
Draft
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
|
|
||
| lifeCycle.subscribe(LifeCycleEventType.RAW_RUM_EVENT_COLLECTED, ({ rawRumEvent, startTime, duration }) => { | ||
| if (rawRumEvent.type === 'long_task') { | ||
| history.add(rawRumEvent.long_task.id, startTime).close(addDuration(startTime, duration!)) |
Collaborator
There was a problem hiding this comment.
🔨 warning: We also send startClock, duration and entryType in the Profiling track.
794e9b1 to
cd45062
Compare
cd45062 to
151e348
Compare
18403ee to
4922f44
Compare
Also make it simpler, as we only care about ids
4922f44 to
7cadb7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make it simpler, as we only care about ids
Motivation
Changes
Test instructions
Checklist