Draft
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
7b107f7 to
6e0e1f7
Compare
rum-events-format was unexpectedly updated. This commit reverts the submodule and generated files to the main branch.
This commit makes it easier to change large functions signatures like `makeRumPublicApi`, `makePreStartRum`, etc.
No need to start the telemetry again in `startLogs` and `startRum`.
This simplifies the code a bit.
…n-manager-with-telemetry
Replace polling-based waitFor with the cleaner collectAsyncCalls pattern which waits for a specific number of spy calls and fails fast on extra calls. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
If consent is revoked while waiting for the session store lock (e.g., Chromium cookie locking), the session should be expired instead of proceeding with initialization. This prevents a race condition where consent revocation during the lock-wait period would be missed.
Tests in 'buffers API calls before starting RUM' section expected synchronous doStartRum calls but session manager initialization is now async. Added proper async/await with collectAsyncCalls to wait for the async callbacks. Fixes race conditions on slower browsers (Chrome 63, Edge 80, Firefox 67).
Tests in 'trackViews mode' section expected synchronous or partially async doStartRum calls but session manager initialization is now fully async. Added proper async/await with collectAsyncCalls to wait for all async callbacks to complete. Fixes race conditions on slower browsers (Edge 80).
ad6ee18 to
7323150
Compare
Base automatically changed from
thomas.lebeau/asyc-session-manager-with-telemetry-merge-main
to
v7
February 10, 2026 10:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adlrb/async-session-manager