Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 5189c30 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fbf5a1ee4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/rum-core/src/domain/view/viewMetrics/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecc7e42b2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/rum-core/src/domain/view/viewMetrics/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackInteractionToNextPaint.ts
Outdated
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5189c309de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (isExperimentalFeatureEnabled(ExperimentalFeature.INP_SUBPARTS)) { | ||
| interactionToNextPaintSubParts = computeInpSubParts(newInteraction, sanitizeInpValue(interactionToNextPaint)) |
There was a problem hiding this comment.
Update INP subparts only when selected interaction changes
interactionToNextPaintSubParts is recomputed on every newInteraction even when newInteraction.duration is unchanged, while time and targetSelector are intentionally not updated in that case. If p98 switches to a different interaction with the same duration (for example when interaction count crosses a 50-interaction bucket and tied durations exist), the payload can mix sub_parts from one interaction with timestamp/target_selector from another, which corrupts attribution data.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| // Create new group | ||
| groupsByInteractionId.set(entry.interactionId, { |
There was a problem hiding this comment.
Cap grouped interaction map per view
With inp_subparts enabled, every interaction ID is stored in groupsByInteractionId and never evicted until stop(), so long-lived views grow this map linearly with user interactions. That introduces unbounded per-view memory growth (despite the existing MAX_INTERACTION_ENTRIES guard for INP tracking) and can degrade pages with many interactions; groups that can no longer affect the p98 candidate should be pruned.
Useful? React with 👍 / 👎.
|
/to-staging |
|
View all feedbacks in Devflow UI.
Commit 5189c309de will soon be integrated into staging-07.
Commit 5189c309de has been merged into staging-07 in merge commit 106178662f. Check out the triggered DDCI request. If you need to revert this integration, you can use the following command: |
…aging-07 Integrated commit sha: 5189c30 Co-authored-by: HugoGarrido <9059402+HugoGarrido@users.noreply.github.com> Co-authored-by: hugo.garridoysaez <hugo.garridoysaez@datadoghq.com>
Motivation
Similar to LCP subparts, this PR goal is to collect INP subparts.
This feature is gated behind the
inp_subpartsexperimental feature flag and is based on Chrome's implementation.You can review commit by commit
TODO rum-events-format PR
Changes
interactionIdto compute the parts with correct values 190734dMapstoring the groups in thestop()callbackTest instructions
Checklist