Skip to content

Changed tracked action to accept ClocksState#4177

Merged
BeltranBulbarellaDD merged 1 commit intomainfrom
beltran.bulbarella/incident-49511-action-duration-calculation
Feb 13, 2026
Merged

Changed tracked action to accept ClocksState#4177
BeltranBulbarellaDD merged 1 commit intomainfrom
beltran.bulbarella/incident-49511-action-duration-calculation

Conversation

@BeltranBulbarellaDD
Copy link
Contributor

@BeltranBulbarellaDD BeltranBulbarellaDD commented Feb 13, 2026

Motivation

This PR changed action duration from:
duration: activityEndTime && elapsed(startClocks.timeStamp, activityEndTime), to
duration = elapsed(startClocks.relative, endTime).

Changes

Change TrackedAction.stop() to accept ClocksState instead of RelativeTime, compute duration using timestamps.

Test instructions

Unit test should suffice.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@BeltranBulbarellaDD BeltranBulbarellaDD requested a review from a team as a code owner February 13, 2026 09:09
@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Feb 13, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 169.43 KiB 169.44 KiB +11 B +0.01%
Rum Profiler 4.29 KiB 4.29 KiB 0 B 0.00%
Rum Recorder 24.61 KiB 24.61 KiB 0 B 0.00%
Logs 56.72 KiB 56.72 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 126.26 KiB 126.29 KiB +26 B +0.02%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.004 0.0046 +15.00%
RUM - add action 0.0137 0.0138 +0.73%
RUM - add error 0.0132 0.0149 +12.88%
RUM - add timing 0.0028 0.0032 +14.29%
RUM - start view 0.0128 0.0138 +7.81%
RUM - start/stop session replay recording 0.0007 0.0007 0.00%
Logs - log message 0.0151 0.0197 +30.46%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 27.30 KiB 26.36 KiB -958 B
RUM - add action 50.78 KiB 49.62 KiB -1.16 KiB
RUM - add timing 26.54 KiB 27.50 KiB +984 B
RUM - add error 57.73 KiB 53.85 KiB -3.89 KiB
RUM - start/stop session replay recording 26.09 KiB 26.29 KiB +208 B
RUM - start view 454.18 KiB 454.68 KiB +510 B
Logs - log message 46.38 KiB 47.20 KiB +834 B

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 13, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 77.28% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7b51251 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@BeltranBulbarellaDD BeltranBulbarellaDD merged commit d1de5f3 into main Feb 13, 2026
22 checks passed
@BeltranBulbarellaDD BeltranBulbarellaDD deleted the beltran.bulbarella/incident-49511-action-duration-calculation branch February 13, 2026 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants