Skip to content

fix: increase bottlecap compile timeout and add retries to integration tests #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jchrostek-dd merged 2 commits into from
Apr 8, 2026
Merged

fix: increase bottlecap compile timeout and add retries to integration tests #1177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9723c61
fix: increase bottlecap compile timeout and add retries to integratio…
jchrostek-dd Apr 8, 2026
0e5915a
fix: restore explicit when conditions for bottlecap compile retry
jchrostek-dd Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .gitlab/templates/pipeline.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ bottlecap ({{ $flavor.name }}):
image: registry.ddbuild.io/images/docker:20.10
tags: ["arch:{{ $flavor.arch }}"]
needs: []
# This job sometimes times out on GitLab for unclear reason.
# Set a short timeout with retries to work around this.
timeout: 10m
# This job sometimes times out on GitLab for unclear reasons.
# Set a timeout with retries to work around this.
timeout: 20m
retry:
max: 2
when:
Copy link
Copy Markdown
Contributor

@duncanista duncanista Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the when

Expand Down Expand Up @@ -464,6 +464,7 @@ integration-suite:
stage: integration-tests
tags: ["arch:amd64"]
image: ${CI_DOCKER_TARGET_IMAGE}:${CI_DOCKER_TARGET_VERSION}
retry: 2
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration-suite job uses retry: 2 without specifying retry conditions. This will retry on ALL failure types, including legitimate test failures that shouldn't be retried. Given that the PR description indicates retries are intended to handle "transient failures from AWS/Datadog API throttling", consider using a more specific retry configuration with when conditions that targets infrastructure/timeout failures rather than test script failures.

Copilot uses AI. Check for mistakes.
parallel:
matrix:
- TEST_SUITE: {{ range (ds "test_suites").test_suites }}
Expand Down
Loading