Skip to content

fix: Bump ujson minimum version to 5.10.0 #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeyzhao2018 merged 2 commits into from
Apr 9, 2026
+4 −1
Merged

fix: Bump ujson minimum version to 5.10.0 #787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97cb992
fix CVE-2026-32874 and CVE-2026-32875
joeyzhao2018 Apr 9, 2026
c3fc366
split the ujson constraint by Python version
joeyzhao2018 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ ddtrace = [
{version = ">=3.19.1,<4", python = ">=3.8,<3.10"},
{version = ">=4.1.1,<5,!=4.6.*", python = ">=3.10"}
]
ujson = ">=5.9.0"
ujson = [
{version = ">=5.10.0,<5.12.0", python = ">=3.8,<3.10"},
Copy link
Copy Markdown
Contributor

@rithikanarayan rithikanarayan Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is the best we can do for Python 3.8 and 3.9 given that v5.12.0 of the ujson library removed support for Python 3.9 ☹️ https://github.com/ultrajson/ultrajson/releases/tag/5.12.0

Copy link
Copy Markdown
Contributor

@rithikanarayan rithikanarayan Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left this comment to remind us why this is structured this way. Shouldn't be a big deal especially since we are removing support for 3.8 and 3.9 in two months.

Copy link
Copy Markdown
Contributor Author

@joeyzhao2018 joeyzhao2018 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the best we can do because security fixes cannot always guarantee coverage for the older versions.

{version = ">=5.12.0", python = ">=3.10"}
]
botocore = { version = "^1.34.0", optional = true }
requests = { version ="^2.22.0", optional = true }
pytest = { version= "^8.0.0", optional = true }
Expand Down
Loading