Add smoke test for websphere-jmx#11077
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom Apr 10, 2026
Merged
Add smoke test for websphere-jmx#11077gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~7002719936, baseline=1.62.0-SNAPSHOT~067d0d2c4b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067777
Total [baseline] (8.876 s) : 0, 8876241
Agent [candidate] (1.059 s) : 0, 1058753
Total [candidate] (8.874 s) : 0, 8873555
section iast
Agent [baseline] (1.234 s) : 0, 1233968
Total [baseline] (9.621 s) : 0, 9620742
Agent [candidate] (1.224 s) : 0, 1224098
Total [candidate] (9.571 s) : 0, 9570851
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~7002719936, baseline=1.62.0-SNAPSHOT~067d0d2c4b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.264 ms) : 0, 1264
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (638.918 ms) : 0, 638918
BytebuddyAgent [candidate] (633.021 ms) : 0, 633021
AgentMeter [baseline] (29.954 ms) : 0, 29954
AgentMeter [candidate] (29.405 ms) : 0, 29405
GlobalTracer [baseline] (251.737 ms) : 0, 251737
GlobalTracer [candidate] (248.715 ms) : 0, 248715
AppSec [baseline] (32.589 ms) : 0, 32589
AppSec [candidate] (32.021 ms) : 0, 32021
Debugger [baseline] (60.272 ms) : 0, 60272
Debugger [candidate] (59.092 ms) : 0, 59092
Remote Config [baseline] (622.303 µs) : 0, 622
Remote Config [candidate] (597.828 µs) : 0, 598
Telemetry [baseline] (8.252 ms) : 0, 8252
Telemetry [candidate] (8.009 ms) : 0, 8009
Flare Poller [baseline] (7.799 ms) : 0, 7799
Flare Poller [candidate] (10.545 ms) : 0, 10545
section iast
crashtracking [baseline] (1.237 ms) : 0, 1237
crashtracking [candidate] (1.236 ms) : 0, 1236
BytebuddyAgent [baseline] (808.411 ms) : 0, 808411
BytebuddyAgent [candidate] (800.943 ms) : 0, 800943
AgentMeter [baseline] (11.476 ms) : 0, 11476
AgentMeter [candidate] (11.389 ms) : 0, 11389
GlobalTracer [baseline] (240.565 ms) : 0, 240565
GlobalTracer [candidate] (240.045 ms) : 0, 240045
IAST [baseline] (26.027 ms) : 0, 26027
IAST [candidate] (25.767 ms) : 0, 25767
AppSec [baseline] (28.256 ms) : 0, 28256
AppSec [candidate] (31.751 ms) : 0, 31751
Debugger [baseline] (65.149 ms) : 0, 65149
Debugger [candidate] (59.182 ms) : 0, 59182
Remote Config [baseline] (1.785 ms) : 0, 1785
Remote Config [candidate] (520.804 µs) : 0, 521
Telemetry [baseline] (11.043 ms) : 0, 11043
Telemetry [candidate] (13.264 ms) : 0, 13264
Flare Poller [baseline] (3.467 ms) : 0, 3467
Flare Poller [candidate] (3.545 ms) : 0, 3545
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~7002719936, baseline=1.62.0-SNAPSHOT~067d0d2c4b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057387
Total [baseline] (11.09 s) : 0, 11090174
Agent [candidate] (1.066 s) : 0, 1066061
Total [candidate] (11.139 s) : 0, 11139313
section appsec
Agent [baseline] (1.248 s) : 0, 1248017
Total [baseline] (11.196 s) : 0, 11196037
Agent [candidate] (1.248 s) : 0, 1247543
Total [candidate] (11.129 s) : 0, 11129017
section iast
Agent [baseline] (1.234 s) : 0, 1233974
Total [baseline] (11.38 s) : 0, 11379973
Agent [candidate] (1.232 s) : 0, 1231621
Total [candidate] (11.197 s) : 0, 11197236
section profiling
Agent [baseline] (1.185 s) : 0, 1184976
Total [baseline] (11.169 s) : 0, 11169431
Agent [candidate] (1.192 s) : 0, 1191533
Total [candidate] (11.064 s) : 0, 11063853
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~7002719936, baseline=1.62.0-SNAPSHOT~067d0d2c4b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (632.881 ms) : 0, 632881
BytebuddyAgent [candidate] (636.869 ms) : 0, 636869
AgentMeter [baseline] (29.451 ms) : 0, 29451
AgentMeter [candidate] (29.879 ms) : 0, 29879
GlobalTracer [baseline] (248.923 ms) : 0, 248923
GlobalTracer [candidate] (251.715 ms) : 0, 251715
AppSec [baseline] (32.07 ms) : 0, 32070
AppSec [candidate] (32.607 ms) : 0, 32607
Debugger [baseline] (60.217 ms) : 0, 60217
Debugger [candidate] (60.98 ms) : 0, 60980
Remote Config [baseline] (601.709 µs) : 0, 602
Remote Config [candidate] (601.039 µs) : 0, 601
Telemetry [baseline] (8.12 ms) : 0, 8120
Telemetry [candidate] (8.198 ms) : 0, 8198
Flare Poller [baseline] (7.643 ms) : 0, 7643
Flare Poller [candidate] (7.674 ms) : 0, 7674
section appsec
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (661.477 ms) : 0, 661477
BytebuddyAgent [candidate] (660.729 ms) : 0, 660729
AgentMeter [baseline] (12.062 ms) : 0, 12062
AgentMeter [candidate] (12.086 ms) : 0, 12086
GlobalTracer [baseline] (248.838 ms) : 0, 248838
GlobalTracer [candidate] (249.116 ms) : 0, 249116
AppSec [baseline] (184.783 ms) : 0, 184783
AppSec [candidate] (184.494 ms) : 0, 184494
Debugger [baseline] (65.885 ms) : 0, 65885
Debugger [candidate] (65.9 ms) : 0, 65900
Remote Config [baseline] (596.892 µs) : 0, 597
Remote Config [candidate] (623.529 µs) : 0, 624
Telemetry [baseline] (8.599 ms) : 0, 8599
Telemetry [candidate] (8.565 ms) : 0, 8565
Flare Poller [baseline] (3.561 ms) : 0, 3561
Flare Poller [candidate] (3.563 ms) : 0, 3563
IAST [baseline] (24.571 ms) : 0, 24571
IAST [candidate] (24.756 ms) : 0, 24756
section iast
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.232 ms) : 0, 1232
BytebuddyAgent [baseline] (809.913 ms) : 0, 809913
BytebuddyAgent [candidate] (806.225 ms) : 0, 806225
AgentMeter [baseline] (11.512 ms) : 0, 11512
AgentMeter [candidate] (11.527 ms) : 0, 11527
GlobalTracer [baseline] (240.626 ms) : 0, 240626
GlobalTracer [candidate] (240.072 ms) : 0, 240072
AppSec [baseline] (31.789 ms) : 0, 31789
AppSec [candidate] (32.03 ms) : 0, 32030
Debugger [baseline] (59.581 ms) : 0, 59581
Debugger [candidate] (61.142 ms) : 0, 61142
Remote Config [baseline] (528.52 µs) : 0, 529
Remote Config [candidate] (536.02 µs) : 0, 536
Telemetry [baseline] (13.109 ms) : 0, 13109
Telemetry [candidate] (13.018 ms) : 0, 13018
Flare Poller [baseline] (3.531 ms) : 0, 3531
Flare Poller [candidate] (3.476 ms) : 0, 3476
IAST [baseline] (25.702 ms) : 0, 25702
IAST [candidate] (25.975 ms) : 0, 25975
section profiling
ProfilingAgent [baseline] (94.381 ms) : 0, 94381
ProfilingAgent [candidate] (94.027 ms) : 0, 94027
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (690.895 ms) : 0, 690895
BytebuddyAgent [candidate] (695.609 ms) : 0, 695609
AgentMeter [baseline] (9.133 ms) : 0, 9133
AgentMeter [candidate] (9.15 ms) : 0, 9150
GlobalTracer [baseline] (207.5 ms) : 0, 207500
GlobalTracer [candidate] (208.86 ms) : 0, 208860
AppSec [baseline] (32.517 ms) : 0, 32517
AppSec [candidate] (32.93 ms) : 0, 32930
Debugger [baseline] (65.936 ms) : 0, 65936
Debugger [candidate] (65.994 ms) : 0, 65994
Remote Config [baseline] (577.819 µs) : 0, 578
Remote Config [candidate] (566.129 µs) : 0, 566
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (7.872 ms) : 0, 7872
Flare Poller [baseline] (3.595 ms) : 0, 3595
Flare Poller [candidate] (3.6 ms) : 0, 3600
Profiling [baseline] (94.934 ms) : 0, 94934
Profiling [candidate] (94.594 ms) : 0, 94594
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~7002719936, baseline=1.62.0-SNAPSHOT~067d0d2c4b
dateFormat X
axisFormat %s
section baseline
no_agent (18.254 ms) : 18069, 18438
. : milestone, 18254,
appsec (19.081 ms) : 18888, 19274
. : milestone, 19081,
code_origins (17.988 ms) : 17810, 18165
. : milestone, 17988,
iast (18.813 ms) : 18622, 19003
. : milestone, 18813,
profiling (18.076 ms) : 17898, 18253
. : milestone, 18076,
tracing (18.859 ms) : 18666, 19051
. : milestone, 18859,
section candidate
no_agent (19.194 ms) : 18994, 19393
. : milestone, 19194,
appsec (19.103 ms) : 18906, 19300
. : milestone, 19103,
code_origins (17.891 ms) : 17712, 18070
. : milestone, 17891,
iast (17.879 ms) : 17703, 18056
. : milestone, 17879,
profiling (19.006 ms) : 18821, 19191
. : milestone, 19006,
tracing (17.833 ms) : 17655, 18011
. : milestone, 17833,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~7002719936, baseline=1.62.0-SNAPSHOT~067d0d2c4b
dateFormat X
axisFormat %s
section baseline
no_agent (1.259 ms) : 1246, 1272
. : milestone, 1259,
iast (3.381 ms) : 3331, 3431
. : milestone, 3381,
iast_FULL (6.235 ms) : 6171, 6299
. : milestone, 6235,
iast_GLOBAL (3.718 ms) : 3655, 3782
. : milestone, 3718,
profiling (2.224 ms) : 2204, 2244
. : milestone, 2224,
tracing (1.844 ms) : 1829, 1858
. : milestone, 1844,
section candidate
no_agent (1.234 ms) : 1222, 1246
. : milestone, 1234,
iast (3.3 ms) : 3254, 3346
. : milestone, 3300,
iast_FULL (6.437 ms) : 6369, 6505
. : milestone, 6437,
iast_GLOBAL (3.616 ms) : 3562, 3670
. : milestone, 3616,
profiling (2.199 ms) : 2178, 2220
. : milestone, 2199,
tracing (1.95 ms) : 1933, 1967
. : milestone, 1950,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~7002719936, baseline=1.62.0-SNAPSHOT~067d0d2c4b
dateFormat X
axisFormat %s
section baseline
no_agent (15.096 s) : 15096000, 15096000
. : milestone, 15096000,
appsec (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
iast (17.907 s) : 17907000, 17907000
. : milestone, 17907000,
iast_GLOBAL (18.049 s) : 18049000, 18049000
. : milestone, 18049000,
profiling (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
tracing (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
section candidate
no_agent (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
appsec (15.097 s) : 15097000, 15097000
. : milestone, 15097000,
iast (18.17 s) : 18170000, 18170000
. : milestone, 18170000,
iast_GLOBAL (18.111 s) : 18111000, 18111000
. : milestone, 18111000,
profiling (14.766 s) : 14766000, 14766000
. : milestone, 14766000,
tracing (15.175 s) : 15175000, 15175000
. : milestone, 15175000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~7002719936, baseline=1.62.0-SNAPSHOT~067d0d2c4b
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.824 ms) : 3602, 4046
. : milestone, 3824,
iast (2.267 ms) : 2198, 2336
. : milestone, 2267,
iast_GLOBAL (2.308 ms) : 2239, 2378
. : milestone, 2308,
profiling (2.523 ms) : 2358, 2688
. : milestone, 2523,
tracing (2.097 ms) : 2043, 2152
. : milestone, 2097,
section candidate
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.802 ms) : 3581, 4024
. : milestone, 3802,
iast (2.265 ms) : 2195, 2334
. : milestone, 2265,
iast_GLOBAL (2.309 ms) : 2240, 2378
. : milestone, 2309,
profiling (2.088 ms) : 2034, 2143
. : milestone, 2088,
tracing (2.071 ms) : 2018, 2124
. : milestone, 2071,
|
mcculls
approved these changes
Apr 10, 2026
Contributor
mcculls
left a comment
There was a problem hiding this comment.
Thanks for the increased coverage!
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds a smoke test for the websphere-jmx instrumentation.
It bootstraps a websphere classic via a docker container (so it's a particular smoke test) and configure its jvm to use the java agent enabling the websphere jmxfetch extension.
Then it bootstrap as well a tiny udp receiver to fetch the metrics that will be sent.
If the instrumentation applies correctly, the websphere vendored metrics will appear, otherwise not.
Note: there are some debugger tests that also spawn a udp server for the same statsd purposes. In the future, we might think about refactoring it into a common test harness.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.