feat: add RC support for enabling LLMO#17232
feat: add RC support for enabling LLMO#17232gh-worker-dd-mergequeue-cf854d[bot] merged 13 commits intomainfrom
Conversation
Codeowners resolved as |
This comment has been minimized.
This comment has been minimized.
48f6699 to
4776fdc
Compare
9128420 to
09485da
Compare
Performance SLOsComparing candidate munir/llm-rc-support (d0c9a96) with baseline main (54e2704) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 102.922µs (SLO: <130.000µs 📉 -20.8%) vs baseline: +0.3% Memory: ✅ 43.901MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ add_inplace_aspectTime: ✅ 101.361µs (SLO: <130.000µs 📉 -22.0%) vs baseline: -1.4% Memory: ✅ 43.805MB (SLO: <46.000MB -4.8%) vs baseline: +5.4% ✅ add_inplace_noaspectTime: ✅ 28.174µs (SLO: <40.000µs 📉 -29.6%) vs baseline: -0.9% Memory: ✅ 43.864MB (SLO: <46.000MB -4.6%) vs baseline: +5.4% ✅ add_noaspectTime: ✅ 48.802µs (SLO: <70.000µs 📉 -30.3%) vs baseline: -1.2% Memory: ✅ 43.894MB (SLO: <46.000MB -4.6%) vs baseline: +5.4% ✅ bytearray_aspectTime: ✅ 258.751µs (SLO: <400.000µs 📉 -35.3%) vs baseline: +0.7% Memory: ✅ 43.826MB (SLO: <46.000MB -4.7%) vs baseline: +5.2% ✅ bytearray_extend_aspectTime: ✅ 653.791µs (SLO: <800.000µs 📉 -18.3%) vs baseline: +1.2% Memory: ✅ 43.840MB (SLO: <46.000MB -4.7%) vs baseline: +5.2% ✅ bytearray_extend_noaspectTime: ✅ 268.556µs (SLO: <400.000µs 📉 -32.9%) vs baseline: +1.9% Memory: ✅ 43.873MB (SLO: <46.000MB -4.6%) vs baseline: +5.5% ✅ bytearray_noaspectTime: ✅ 142.873µs (SLO: <300.000µs 📉 -52.4%) vs baseline: +0.6% Memory: ✅ 43.866MB (SLO: <46.000MB -4.6%) vs baseline: +5.5% ✅ bytes_aspectTime: ✅ 218.426µs (SLO: <300.000µs 📉 -27.2%) vs baseline: -0.9% Memory: ✅ 43.828MB (SLO: <46.000MB -4.7%) vs baseline: +5.4% ✅ bytes_noaspectTime: ✅ 135.094µs (SLO: <200.000µs 📉 -32.5%) vs baseline: ~same Memory: ✅ 43.772MB (SLO: <46.000MB -4.8%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 3.845ms (SLO: <5.000ms 📉 -23.1%) vs baseline: +0.1% Memory: ✅ 43.852MB (SLO: <46.000MB -4.7%) vs baseline: +5.5% ✅ bytesio_noaspectTime: ✅ 321.687µs (SLO: <420.000µs 📉 -23.4%) vs baseline: -0.2% Memory: ✅ 43.841MB (SLO: <46.000MB -4.7%) vs baseline: +5.4% ✅ capitalize_aspectTime: ✅ 88.881µs (SLO: <300.000µs 📉 -70.4%) vs baseline: +0.3% Memory: ✅ 43.813MB (SLO: <46.000MB -4.8%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 276.690µs (SLO: <300.000µs -7.8%) vs baseline: +7.8% Memory: ✅ 43.883MB (SLO: <46.000MB -4.6%) vs baseline: +5.4% ✅ casefold_aspectTime: ✅ 87.865µs (SLO: <500.000µs 📉 -82.4%) vs baseline: -0.3% Memory: ✅ 43.828MB (SLO: <46.000MB -4.7%) vs baseline: +5.2% ✅ casefold_noaspectTime: ✅ 321.838µs (SLO: <500.000µs 📉 -35.6%) vs baseline: +3.4% Memory: ✅ 43.857MB (SLO: <46.000MB -4.7%) vs baseline: +5.3% ✅ decode_aspectTime: ✅ 87.035µs (SLO: <100.000µs 📉 -13.0%) vs baseline: +0.5% Memory: ✅ 43.829MB (SLO: <46.000MB -4.7%) vs baseline: +5.2% ✅ decode_noaspectTime: ✅ 157.226µs (SLO: <210.000µs 📉 -25.1%) vs baseline: +1.5% Memory: ✅ 43.857MB (SLO: <46.000MB -4.7%) vs baseline: +5.3% ✅ encode_aspectTime: ✅ 85.232µs (SLO: <200.000µs 📉 -57.4%) vs baseline: +1.0% Memory: ✅ 43.836MB (SLO: <46.000MB -4.7%) vs baseline: +5.2% ✅ encode_noaspectTime: ✅ 144.967µs (SLO: <200.000µs 📉 -27.5%) vs baseline: +1.5% Memory: ✅ 43.772MB (SLO: <46.000MB -4.8%) vs baseline: +5.3% ✅ format_aspectTime: ✅ 14.587ms (SLO: <19.200ms 📉 -24.0%) vs baseline: -0.1% Memory: ✅ 43.877MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ format_map_aspectTime: ✅ 16.381ms (SLO: <21.500ms 📉 -23.8%) vs baseline: -0.5% Memory: ✅ 43.871MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ format_map_noaspectTime: ✅ 371.409µs (SLO: <500.000µs 📉 -25.7%) vs baseline: -1.6% Memory: ✅ 43.901MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ format_noaspectTime: ✅ 310.007µs (SLO: <500.000µs 📉 -38.0%) vs baseline: -1.9% Memory: ✅ 43.833MB (SLO: <46.000MB -4.7%) vs baseline: +5.5% ✅ index_aspectTime: ✅ 140.275µs (SLO: <300.000µs 📉 -53.2%) vs baseline: 📈 +11.8% Memory: ✅ 43.773MB (SLO: <46.000MB -4.8%) vs baseline: +5.1% ✅ index_noaspectTime: ✅ 40.687µs (SLO: <300.000µs 📉 -86.4%) vs baseline: -0.5% Memory: ✅ 43.800MB (SLO: <46.000MB -4.8%) vs baseline: +5.3% ✅ join_aspectTime: ✅ 205.542µs (SLO: <300.000µs 📉 -31.5%) vs baseline: -6.0% Memory: ✅ 43.810MB (SLO: <46.000MB -4.8%) vs baseline: +5.2% ✅ join_noaspectTime: ✅ 140.123µs (SLO: <300.000µs 📉 -53.3%) vs baseline: -2.4% Memory: ✅ 44.153MB (SLO: <46.000MB -4.0%) vs baseline: +5.9% ✅ ljust_aspectTime: ✅ 504.391µs (SLO: <700.000µs 📉 -27.9%) vs baseline: -2.7% Memory: ✅ 43.917MB (SLO: <46.000MB -4.5%) vs baseline: +5.2% ✅ ljust_noaspectTime: ✅ 280.090µs (SLO: <300.000µs -6.6%) vs baseline: +4.1% Memory: ✅ 43.837MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 311.461µs (SLO: <500.000µs 📉 -37.7%) vs baseline: -1.5% Memory: ✅ 43.899MB (SLO: <46.000MB -4.6%) vs baseline: +5.6% ✅ lower_noaspectTime: ✅ 245.168µs (SLO: <300.000µs 📉 -18.3%) vs baseline: +1.5% Memory: ✅ 43.995MB (SLO: <46.000MB -4.4%) vs baseline: +5.1% ✅ lstrip_aspectTime: ✅ 0.279ms (SLO: <3.000ms 📉 -90.7%) vs baseline: -1.4% Memory: ✅ 43.883MB (SLO: <46.000MB -4.6%) vs baseline: +5.5% ✅ lstrip_noaspectTime: ✅ 0.180ms (SLO: <3.000ms 📉 -94.0%) vs baseline: +0.2% Memory: ✅ 43.991MB (SLO: <46.000MB -4.4%) vs baseline: +5.6% ✅ modulo_aspectTime: ✅ 14.259ms (SLO: <18.750ms 📉 -24.0%) vs baseline: ~same Memory: ✅ 43.985MB (SLO: <46.000MB -4.4%) vs baseline: +5.6% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.781ms (SLO: <19.350ms 📉 -23.6%) vs baseline: -0.3% Memory: ✅ 44.053MB (SLO: <46.000MB -4.2%) vs baseline: +5.5% ✅ modulo_aspect_for_bytesTime: ✅ 14.347ms (SLO: <18.900ms 📉 -24.1%) vs baseline: -0.2% Memory: ✅ 43.850MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.621ms (SLO: <19.150ms 📉 -23.7%) vs baseline: -0.2% Memory: ✅ 43.970MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ modulo_noaspectTime: ✅ 0.368ms (SLO: <3.000ms 📉 -87.7%) vs baseline: -1.9% Memory: ✅ 43.813MB (SLO: <46.000MB -4.8%) vs baseline: +5.1% ✅ replace_aspectTime: ✅ 18.444ms (SLO: <24.000ms 📉 -23.1%) vs baseline: +0.5% Memory: ✅ 43.964MB (SLO: <46.000MB -4.4%) vs baseline: +5.5% ✅ replace_noaspectTime: ✅ 284.908µs (SLO: <400.000µs 📉 -28.8%) vs baseline: -0.5% Memory: ✅ 43.916MB (SLO: <46.000MB -4.5%) vs baseline: +5.4% ✅ repr_aspectTime: ✅ 319.456µs (SLO: <420.000µs 📉 -23.9%) vs baseline: -1.7% Memory: ✅ 43.839MB (SLO: <46.000MB -4.7%) vs baseline: +5.3% ✅ repr_noaspectTime: ✅ 46.706µs (SLO: <90.000µs 📉 -48.1%) vs baseline: +0.2% Memory: ✅ 43.946MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ rstrip_aspectTime: ✅ 379.095µs (SLO: <500.000µs 📉 -24.2%) vs baseline: -4.0% Memory: ✅ 43.904MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ rstrip_noaspectTime: ✅ 184.938µs (SLO: <300.000µs 📉 -38.4%) vs baseline: +2.1% Memory: ✅ 43.919MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ slice_aspectTime: ✅ 186.197µs (SLO: <300.000µs 📉 -37.9%) vs baseline: -0.5% Memory: ✅ 43.760MB (SLO: <46.000MB -4.9%) vs baseline: +5.3% ✅ slice_noaspectTime: ✅ 54.370µs (SLO: <90.000µs 📉 -39.6%) vs baseline: ~same Memory: ✅ 43.853MB (SLO: <46.000MB -4.7%) vs baseline: +5.5% ✅ stringio_aspectTime: ✅ 4.466ms (SLO: <5.000ms 📉 -10.7%) vs baseline: 📈 +14.8% Memory: ✅ 43.909MB (SLO: <46.000MB -4.5%) vs baseline: +5.4% ✅ stringio_noaspectTime: ✅ 349.159µs (SLO: <500.000µs 📉 -30.2%) vs baseline: -0.8% Memory: ✅ 43.877MB (SLO: <46.000MB -4.6%) vs baseline: +5.5% ✅ strip_aspectTime: ✅ 279.584µs (SLO: <350.000µs 📉 -20.1%) vs baseline: +1.7% Memory: ✅ 43.898MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ strip_noaspectTime: ✅ 176.719µs (SLO: <240.000µs 📉 -26.4%) vs baseline: -1.2% Memory: ✅ 43.911MB (SLO: <46.000MB -4.5%) vs baseline: +5.4% ✅ swapcase_aspectTime: ✅ 334.361µs (SLO: <500.000µs 📉 -33.1%) vs baseline: -2.9% Memory: ✅ 43.865MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ swapcase_noaspectTime: ✅ 282.102µs (SLO: <400.000µs 📉 -29.5%) vs baseline: +3.4% Memory: ✅ 43.911MB (SLO: <46.000MB -4.5%) vs baseline: +5.4% ✅ title_aspectTime: ✅ 326.146µs (SLO: <500.000µs 📉 -34.8%) vs baseline: -3.6% Memory: ✅ 43.799MB (SLO: <46.000MB -4.8%) vs baseline: +5.4% ✅ title_noaspectTime: ✅ 264.375µs (SLO: <400.000µs 📉 -33.9%) vs baseline: -0.4% Memory: ✅ 43.810MB (SLO: <46.000MB -4.8%) vs baseline: +5.4% ✅ translate_aspectTime: ✅ 518.219µs (SLO: <700.000µs 📉 -26.0%) vs baseline: +1.3% Memory: ✅ 43.837MB (SLO: <46.000MB -4.7%) vs baseline: +5.1% ✅ translate_noaspectTime: ✅ 434.439µs (SLO: <500.000µs 📉 -13.1%) vs baseline: +0.3% Memory: ✅ 43.923MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ upper_aspectTime: ✅ 305.692µs (SLO: <500.000µs 📉 -38.9%) vs baseline: -2.6% Memory: ✅ 43.819MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ upper_noaspectTime: ✅ 256.288µs (SLO: <400.000µs 📉 -35.9%) vs baseline: +6.0% Memory: ✅ 43.910MB (SLO: <46.000MB -4.5%) vs baseline: +5.6% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 533.922µs (SLO: <700.000µs 📉 -23.7%) vs baseline: 📈 +22.9% Memory: ✅ 43.961MB (SLO: <46.000MB -4.4%) vs baseline: +5.5% ✅ ospathbasename_noaspectTime: ✅ 444.211µs (SLO: <700.000µs 📉 -36.5%) vs baseline: +0.2% Memory: ✅ 43.904MB (SLO: <46.000MB -4.6%) vs baseline: +5.4% ✅ ospathjoin_aspectTime: ✅ 638.032µs (SLO: <700.000µs -8.9%) vs baseline: +0.1% Memory: ✅ 43.816MB (SLO: <46.000MB -4.7%) vs baseline: +5.8% ✅ ospathjoin_noaspectTime: ✅ 636.494µs (SLO: <700.000µs -9.1%) vs baseline: -0.6% Memory: ✅ 43.844MB (SLO: <46.000MB -4.7%) vs baseline: +5.7% ✅ ospathnormcase_aspectTime: ✅ 362.678µs (SLO: <700.000µs 📉 -48.2%) vs baseline: +1.8% Memory: ✅ 43.909MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ ospathnormcase_noaspectTime: ✅ 376.814µs (SLO: <700.000µs 📉 -46.2%) vs baseline: +3.8% Memory: ✅ 43.909MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ ospathsplit_aspectTime: ✅ 493.965µs (SLO: <700.000µs 📉 -29.4%) vs baseline: -0.3% Memory: ✅ 43.856MB (SLO: <46.000MB -4.7%) vs baseline: +5.2% ✅ ospathsplit_noaspectTime: ✅ 507.276µs (SLO: <700.000µs 📉 -27.5%) vs baseline: ~same Memory: ✅ 43.871MB (SLO: <46.000MB -4.6%) vs baseline: +5.6% ✅ ospathsplitdrive_aspectTime: ✅ 388.788µs (SLO: <700.000µs 📉 -44.5%) vs baseline: +1.4% Memory: ✅ 43.754MB (SLO: <46.000MB -4.9%) vs baseline: +5.6% ✅ ospathsplitdrive_noaspectTime: ✅ 72.278µs (SLO: <700.000µs 📉 -89.7%) vs baseline: -0.2% Memory: ✅ 43.825MB (SLO: <46.000MB -4.7%) vs baseline: +5.4% ✅ ospathsplitext_aspectTime: ✅ 477.060µs (SLO: <700.000µs 📉 -31.8%) vs baseline: +2.3% Memory: ✅ 43.872MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ ospathsplitext_noaspectTime: ✅ 491.084µs (SLO: <700.000µs 📉 -29.8%) vs baseline: +3.7% Memory: ✅ 43.802MB (SLO: <46.000MB -4.8%) vs baseline: +5.4% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 21.035ms (SLO: <22.300ms -5.7%) vs baseline: +6.8% Memory: ✅ 71.267MB (SLO: <73.500MB -3.0%) vs baseline: +8.1% ✅ exception-replay-enabledTime: ✅ 1.370ms (SLO: <1.450ms -5.5%) vs baseline: ~same Memory: ✅ 69.585MB (SLO: <71.500MB -2.7%) vs baseline: +8.2% ✅ iastTime: ✅ 21.015ms (SLO: <22.250ms -5.5%) vs baseline: +6.0% Memory: ✅ 71.374MB (SLO: <75.000MB -4.8%) vs baseline: +8.2% ✅ profilerTime: ✅ 15.145ms (SLO: <16.550ms -8.5%) vs baseline: +0.1% Memory: ✅ 59.978MB (SLO: <61.000MB 🟡 -1.7%) vs baseline: +5.6% ✅ resource-renamingTime: ✅ 20.745ms (SLO: <21.750ms -4.6%) vs baseline: +5.5% Memory: ✅ 71.299MB (SLO: <73.500MB -3.0%) vs baseline: +8.0% ✅ span-code-originTime: ✅ 21.427ms (SLO: <28.200ms 📉 -24.0%) vs baseline: +7.9% Memory: ✅ 71.297MB (SLO: <75.000MB -4.9%) vs baseline: +7.9% ✅ tracerTime: ✅ 21.049ms (SLO: <21.750ms -3.2%) vs baseline: +6.8% Memory: ✅ 71.291MB (SLO: <75.000MB -4.9%) vs baseline: +8.1% ✅ tracer-and-profilerTime: ✅ 21.031ms (SLO: <23.500ms 📉 -10.5%) vs baseline: +0.2% Memory: ✅ 73.219MB (SLO: <75.000MB -2.4%) vs baseline: +7.9% ✅ tracer-dont-create-db-spansTime: ✅ 21.021ms (SLO: <21.500ms -2.2%) vs baseline: +6.3% Memory: ✅ 71.350MB (SLO: <75.000MB -4.9%) vs baseline: +8.2% ✅ tracer-minimalTime: ✅ 17.812ms (SLO: <18.500ms -3.7%) vs baseline: +7.0% Memory: ✅ 71.349MB (SLO: <75.000MB -4.9%) vs baseline: +8.2% ✅ tracer-nativeTime: ✅ 20.863ms (SLO: <21.750ms -4.1%) vs baseline: +6.3% Memory: ✅ 71.299MB (SLO: <72.500MB 🟡 -1.7%) vs baseline: +8.1% ✅ tracer-no-cachesTime: ✅ 18.905ms (SLO: <19.650ms -3.8%) vs baseline: +8.4% Memory: ✅ 71.389MB (SLO: <75.000MB -4.8%) vs baseline: +8.2% ✅ tracer-no-databasesTime: ✅ 20.693ms (SLO: <21.100ms 🟡 -1.9%) vs baseline: +7.4% Memory: ✅ 71.277MB (SLO: <75.000MB -5.0%) vs baseline: +8.1% ✅ tracer-no-middlewareTime: ✅ 20.768ms (SLO: <21.500ms -3.4%) vs baseline: +6.9% Memory: ✅ 71.200MB (SLO: <75.000MB -5.1%) vs baseline: +8.1% ✅ tracer-no-templatesTime: ✅ 20.753ms (SLO: <22.000ms -5.7%) vs baseline: +6.8% Memory: ✅ 71.356MB (SLO: <73.500MB -2.9%) vs baseline: +8.1% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 40.807ms (SLO: <47.150ms 📉 -13.5%) vs baseline: -1.3% Memory: ✅ 41.294MB (SLO: <47.000MB 📉 -12.1%) vs baseline: +5.6% ✅ add-metricsTime: ✅ 235.191ms (SLO: <344.800ms 📉 -31.8%) vs baseline: -1.5% Memory: ✅ 45.658MB (SLO: <47.500MB -3.9%) vs baseline: +5.2% ✅ add-tagsTime: ✅ 277.013ms (SLO: <330.000ms 📉 -16.1%) vs baseline: +1.6% Memory: ✅ 45.763MB (SLO: <47.500MB -3.7%) vs baseline: +5.4% ✅ get-contextTime: ✅ 83.827ms (SLO: <92.350ms -9.2%) vs baseline: ~same Memory: ✅ 41.425MB (SLO: <46.500MB 📉 -10.9%) vs baseline: +5.1% ✅ is-recordingTime: ✅ 39.019ms (SLO: <44.500ms 📉 -12.3%) vs baseline: -0.9% Memory: ✅ 41.152MB (SLO: <47.500MB 📉 -13.4%) vs baseline: +5.5% ✅ record-exceptionTime: ✅ 61.028ms (SLO: <67.650ms -9.8%) vs baseline: -0.3% Memory: ✅ 41.781MB (SLO: <47.000MB 📉 -11.1%) vs baseline: +5.5% ✅ set-statusTime: ✅ 45.240ms (SLO: <50.400ms 📉 -10.2%) vs baseline: +0.1% Memory: ✅ 41.221MB (SLO: <47.000MB 📉 -12.3%) vs baseline: +5.6% ✅ startTime: ✅ 40.060ms (SLO: <44.500ms -10.0%) vs baseline: +3.7% Memory: ✅ 41.088MB (SLO: <47.000MB 📉 -12.6%) vs baseline: +5.4% ✅ start-finishTime: ✅ 90.180ms (SLO: <91.000ms 🟡 -0.9%) vs baseline: +0.3% Memory: ✅ 38.692MB (SLO: <46.500MB 📉 -16.8%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 91.717ms (SLO: <92.000ms 🟡 -0.3%) vs baseline: +0.2% Memory: ✅ 38.692MB (SLO: <46.500MB 📉 -16.8%) vs baseline: +5.2% ✅ update-nameTime: ✅ 40.152ms (SLO: <45.150ms 📉 -11.1%) vs baseline: ~same Memory: ✅ 41.189MB (SLO: <47.000MB 📉 -12.4%) vs baseline: +5.1% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 312.834ms (SLO: <320.950ms -2.5%) vs baseline: +0.2% Memory: ✅ 37.473MB (SLO: <38.750MB -3.3%) vs baseline: +5.8% ✅ deep-profiledTime: ✅ 329.889ms (SLO: <359.150ms -8.1%) vs baseline: ~same Memory: ✅ 43.706MB (SLO: <46.000MB -5.0%) vs baseline: +5.5% ✅ mediumTime: ✅ 7.416ms (SLO: <7.450ms 🟡 -0.5%) vs baseline: ~same Memory: ✅ 36.137MB (SLO: <38.000MB -4.9%) vs baseline: +5.1% ✅ shallowTime: ✅ 1.049ms (SLO: <1.050ms 🟡 -0.1%) vs baseline: +1.9% Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.3% 🟡 span - 26/26✅ add-eventTime: ✅ 19.589ms (SLO: <22.500ms 📉 -12.9%) vs baseline: -1.1% Memory: ✅ 38.389MB (SLO: <53.000MB 📉 -27.6%) vs baseline: +5.3% ✅ add-metricsTime: ✅ 88.970ms (SLO: <93.500ms -4.8%) vs baseline: -0.8% Memory: ✅ 42.880MB (SLO: <53.000MB 📉 -19.1%) vs baseline: +5.2% ✅ add-tagsTime: ✅ 146.961ms (SLO: <155.000ms -5.2%) vs baseline: -0.9% Memory: ✅ 42.952MB (SLO: <53.000MB 📉 -19.0%) vs baseline: +5.2% ✅ get-contextTime: ✅ 18.753ms (SLO: <20.500ms -8.5%) vs baseline: -1.1% Memory: ✅ 38.419MB (SLO: <53.000MB 📉 -27.5%) vs baseline: +5.5% ✅ is-recordingTime: ✅ 18.870ms (SLO: <20.500ms -8.0%) vs baseline: -1.1% Memory: ✅ 38.340MB (SLO: <53.000MB 📉 -27.7%) vs baseline: +5.4% ✅ record-exceptionTime: ✅ 38.474ms (SLO: <41.000ms -6.2%) vs baseline: -0.2% Memory: ✅ 38.851MB (SLO: <53.000MB 📉 -26.7%) vs baseline: +5.6% ✅ set-statusTime: ✅ 20.665ms (SLO: <22.000ms -6.1%) vs baseline: -1.0% Memory: ✅ 38.415MB (SLO: <53.000MB 📉 -27.5%) vs baseline: +5.7% ✅ startTime: ✅ 19.754ms (SLO: <20.500ms -3.6%) vs baseline: +4.4% Memory: ✅ 38.453MB (SLO: <53.000MB 📉 -27.4%) vs baseline: +5.6% ✅ start-finishTime: ✅ 57.944ms (SLO: <58.500ms 🟡 -1.0%) vs baseline: -0.4% Memory: ✅ 36.078MB (SLO: <38.000MB -5.1%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 59.290ms (SLO: <60.000ms 🟡 -1.2%) vs baseline: -0.6% Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +5.5% ✅ start-finish-traceid128Time: ✅ 60.446ms (SLO: <62.000ms -2.5%) vs baseline: -0.7% Memory: ✅ 36.176MB (SLO: <38.000MB -4.8%) vs baseline: +5.3% ✅ start-traceid128Time: ✅ 18.719ms (SLO: <22.500ms 📉 -16.8%) vs baseline: -1.1% Memory: ✅ 38.371MB (SLO: <53.000MB 📉 -27.6%) vs baseline: +5.4% ✅ update-nameTime: ✅ 19.279ms (SLO: <22.000ms 📉 -12.4%) vs baseline: -1.4% Memory: ✅ 38.433MB (SLO: <53.000MB 📉 -27.5%) vs baseline: +5.7% 🟡 tracer - 6/6✅ largeTime: ✅ 33.058ms (SLO: <32.950ms +0.3%) vs baseline: -0.5% Memory: ✅ 37.886MB (SLO: <39.250MB -3.5%) vs baseline: +6.6% ✅ mediumTime: ✅ 3.357ms (SLO: <3.500ms -4.1%) vs baseline: +0.4% Memory: ✅ 36.274MB (SLO: <38.750MB -6.4%) vs baseline: +5.5% ✅ smallTime: ✅ 386.125µs (SLO: <390.000µs 🟡 -1.0%) vs baseline: +3.7% Memory: ✅ 36.156MB (SLO: <38.750MB -6.7%) vs baseline: +4.7%
|
f4f043a to
0941dd2
Compare
620dc3e to
767e2cf
Compare
ZStriker19
left a comment
There was a problem hiding this comment.
Looks good, just left a couple comments.
a9d9dd1 to
fc801f2
Compare
ncybul
left a comment
There was a problem hiding this comment.
Just a few comments but overall LGTM!
d31fa4b to
d50872a
Compare
55b4866 to
0f19216
Compare
|
Blocked by: DataDog/system-tests#6719 |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
Description
Staging POC (M0) for LLMObs 1-click enablement via Remote Configuration.
New:
ddtrace/llmobs/product.py— LLMObs RC product that hooks into the existingAPM_TRACINGRC flow:apm_tracing_rcreceivesllmobs.enabled/llmobs.ml_app_namefrom RC and callsLLMObs.enable()/LLMObs.disable()at runtime without a restart_track_enabled_llm_integrationstags the RCclient_tracerwith active LLM integrations so the backend can identify LLM-capable services for 1-click enablementddtrace/llmobs/_llmobs.py— splitsSUPPORTED_LLMOBS_INTEGRATIONS(LLM frameworks) from_INTEGRATIONS_W_PROPAGATION_SUPPORT(HTTP adapters)ddtrace/internal/settings/_config.py— registers_llmobs_enabledand_llmobs_ml_appin_default_config()so RC can override them via the standard config precedence chainTesting
No tests yet — M0 is validated manually on staging.
Risks
1<<48is a placeholder; must be confirmed with dd-go before GALLMObs.enable()is called from the RC poll thread (pre-existing thread-safety limitation)Additional Notes
Requires backend changes in dd-go: extend
LibConfigwithllmobs.enabled/llmobs.ml_app_nameand confirm capability bit.