Skip to content

Add support for Ruby HEAD (version 4.0)#5043

Merged
ivoanjo merged 1 commit intoDataDog:masterfrom
composerinteralia:max-ruby-version-4.0
Nov 19, 2025
Merged

Add support for Ruby HEAD (version 4.0)#5043
ivoanjo merged 1 commit intoDataDog:masterfrom
composerinteralia:max-ruby-version-4.0

Conversation

@composerinteralia
Copy link
Copy Markdown
Contributor

What does this PR do?

Changes the max Ruby version to 4.0

Motivation:

Ruby changed the development branch from 3.5 to 4.0 in ruby/ruby@6d81969 Updating the version here allows folks to continue testing the gem against Ruby HEAD (4.0.0.dev)

Change log entry

Ruby changed the development branch from 3.5 to 4.0 in
ruby/ruby@6d81969
Updating the version here allows folks to continue testing the gem
against Ruby HEAD (4.0.0.dev)
@composerinteralia composerinteralia requested a review from a team as a code owner November 12, 2025 19:39
@github-actions github-actions Bot added the release Official release label Nov 12, 2025
@composerinteralia composerinteralia changed the title Change max ruby version to < 4.0 Add support for Ruby HEAD (version 4.0) Nov 13, 2025
Copy link
Copy Markdown
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have Ruby 4.0 in CI and given a lack of a released preview version, testing against 4.0 would mean testing against HEAD which is rapidly changing. What do you think about a note I added to clarify that we do not officially test against 4.0 yet?

Comment thread lib/datadog/version.rb
@ctrochalakis
Copy link
Copy Markdown

We don't currently have Ruby 4.0 in CI and given a lack of a released preview version, testing against 4.0 would mean testing against HEAD which is rapidly changing. What do you think about a note I added to clarify that we do not officially test against 4.0 yet?

Hello, v4.0.0-preview2 is already released, and a new image tag will be pushed soon.

Copy link
Copy Markdown
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM thanks for sending this our way!

Comment thread lib/datadog/version.rb
@ivoanjo
Copy link
Copy Markdown
Member

ivoanjo commented Nov 19, 2025

I'll make sure this lands in master asap :)

@ivoanjo ivoanjo added this to the 2.23.0 milestone Nov 19, 2025
@ivoanjo ivoanjo merged commit 276464a into DataDog:master Nov 19, 2025
784 of 1055 checks passed
@mensfeld
Copy link
Copy Markdown

@ivoanjo any timeline to release it to rubygems? Depending on that I will either silence the DD integrations of mine

image

@ivoanjo
Copy link
Copy Markdown
Member

ivoanjo commented Nov 24, 2025

@mensfeld unfortunately the next release has been held back for other very unrelated reasons and should only happen after the first week of December. Sorry!

@mensfeld
Copy link
Copy Markdown

@ivoanjo no worries at all! The only thing (if I may) ask is to ping me here when it's done so I can disable my exclusions and re-run all including DD setup in Karafka against 4.0 🙏 take your time

@ivoanjo
Copy link
Copy Markdown
Member

ivoanjo commented Nov 24, 2025

Deal, I'll make a note and for sure will ping you!

@ivoanjo
Copy link
Copy Markdown
Member

ivoanjo commented Dec 12, 2025

@mensfeld as promised (thanks for the patience!) there's now a freshly-baked version 2.23.0 of the datadog gem up on rubygems.org

@vpellan vpellan added the community Was opened by a community member label Jan 6, 2026
mensfeld added a commit to karafka/karafka that referenced this pull request Apr 17, 2026
The datadog gem now supports Ruby 4.0 since v2.24.0 (Jan 2026).
These specs were excluded in #2922 as a precaution when dd-trace-rb
hadn't yet released Ruby 4.0 support. That support has since shipped
(DataDog/dd-trace-rb#5043), so the exclusion is no longer needed.
mensfeld added a commit to karafka/karafka that referenced this pull request Apr 17, 2026
The datadog gem now supports Ruby 4.0 since v2.24.0 (Jan 2026).
These specs were excluded in #2922 as a precaution when dd-trace-rb
hadn't yet released Ruby 4.0 support. That support has since shipped
(DataDog/dd-trace-rb#5043), so the exclusion is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Was opened by a community member release Official release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants