Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions kuma/assets/monitors/no_leader_detected.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
"include_tags": true,
"new_group_delay": 300,
"silenced": {},
"notify_no_data": true,
"no_data_timeframe": 20,
"on_missing_data": "show_and_notify_no_data",
"renotify_interval": 300,
"require_full_window": true,
"evaluation_delay": 60
Expand Down
3 changes: 1 addition & 2 deletions openai/assets/monitors/token_usage.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@
"name": "[OpenAI] Abnormally high token usage ",
"options": {
"include_tags": false,
"no_data_timeframe": 10,
"on_missing_data": "default",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve no-data status for non-notifying monitors

For monitors that previously had notify_no_data: false, this should migrate to on_missing_data: "show_no_data" rather than "default": Datadog's migration guide maps the legacy “Do not notify if data is missing” behavior to show_no_data, while default evaluates missing sum/count data as zero or keeps the last status for other aggregations. As written, this OpenAI monitor (and the two WebLogic monitors changed the same way) will no longer enter No Data when the integration stops reporting, hiding missing telemetry from monitor status/SLO consumers even though the old template surfaced it without paging.

Useful? React with 👍 / 👎.

"notify_audit": false,
"notify_no_data": false,
"renotify_interval": 0,
"require_full_window": false,
"threshold_windows": {
Expand Down
3 changes: 1 addition & 2 deletions velero/assets/monitors/backup_failures.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
},
"notify_audit": false,
"require_full_window": false,
"notify_no_data": true,
"no_data_timeframe": 480,
"on_missing_data": "show_and_notify_no_data",
"renotify_interval": 240,
"include_tags": true,
"evaluation_delay": 900,
Expand Down
3 changes: 1 addition & 2 deletions velero/assets/monitors/backup_staleness.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
},
"notify_audit": false,
"require_full_window": false,
"notify_no_data": true,
"no_data_timeframe": 120,
"on_missing_data": "show_and_notify_no_data",
"renotify_interval": 60,
"include_tags": true,
"evaluation_delay": 300,
Expand Down
5 changes: 2 additions & 3 deletions velero/assets/monitors/restore_failures.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@
},
"notify_audit": false,
"require_full_window": false,
"notify_no_data": true,
"on_missing_data": "show_and_notify_no_data",
"include_tags": true,
"evaluation_delay": 300,
"no_data_timeframe": 30
"evaluation_delay": 300
},
"priority": 1
},
Expand Down
3 changes: 1 addition & 2 deletions weblogic/assets/monitors/active_threads.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
"include_tags": true,
"locked": false,
"new_group_delay": 60,
"no_data_timeframe": 10,
"on_missing_data": "default",
"notify_audit": false,
"notify_no_data": false,
"renotify_interval": 0,
"require_full_window": false,
"silenced": {},
Expand Down
3 changes: 1 addition & 2 deletions weblogic/assets/monitors/stuck_threads.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
"escalation_message": "",
"include_tags": true,
"locked": false,
"no_data_timeframe": 10,
"on_missing_data": "default",
"notify_audit": false,
"notify_no_data": false,
"renotify_interval": 0,
"require_full_window": false,
"silenced": {},
Expand Down
Loading