Add ddev validate to ddev tools#23636
Open
luisorofino wants to merge 4 commits into
Open
Conversation
DdevValidateTool to the AI shell tools
Contributor
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: b288a9b | Docs | Datadog PR Page | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
DdevValidateTool to the AI shell tools
Contributor
Validation ReportAll 20 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
DdevValidateToolshell tool to the AI agent harness atddev/src/ddev/ai/tools/shell/ddev/validate.py. The tool wrapsddev validatewith four subcommands:config— validatesassets/configuration/spec.yamlagainstdata/conf.yaml.example.models— validatesspec.yamlagainstdatadog_checks/<integration>/config_models/.metadata— validatesmetadata.csv.all— runs all ~20 validators in parallel. Intended as a final sweep, since it takes considerably longer than the targeted three.A
syncboolean maps to--syncfor the targeted subcommands and to--fixforall.Tests covering all subcommand shapes are in
ddev/tests/ai/tools/shell/ddev/test_ddev_tools.py.Motivation
The AI agent harness could edit
assets/configuration/spec.yamlbut had no way to subsequently runddev validate config --syncorddev validate models --syncto regenerate the derived files (conf.yaml.example,config_models/) from the updated spec. Without this tool, an agent that edits the spec produces an integration with stale generated files, causing CI to reject the PR.The
allsubcommand additionally lets the agent run a final pre-commit sweep covering validators the targeted three do not (license headers, imports, readmes, codeowners, etc.).DdevValidateToolcloses this gap and completes the integration authoring lifecycle that the shell tools layer exposes to the agent.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged