fix: add MarkCacheBytes to SystemMetrics query mapping#23677
Draft
Victor-Davidescu wants to merge 1 commit into
Draft
fix: add MarkCacheBytes to SystemMetrics query mapping#23677Victor-Davidescu wants to merge 1 commit into
Victor-Davidescu wants to merge 1 commit into
Conversation
5618bba to
3dded26
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
ba5a561 to
46b9619
Compare
46b9619 to
050d606
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
MarkCacheBytesto theSystemMetricsquery mapping so that theclickhouse.table.mergetree.storage.mark.cachemetric is collected for users running ClickHouse 25.x+.The existing entry in
SystemAsynchronousMetricsis kept for backwards compatibility with older ClickHouse versions. Only one table will ever contain the metric, so there's no risk of double-reporting.Motivation
ClickHouse PR #81023 (merged June 2025) moved
MarkCacheBytesfromsystem.asynchronous_metricstosystem.metrics. As a result, theclickhouse.table.mergetree.storage.mark.cachemetric is no longer collected for users running ClickHouse 25.x+.Verified against ClickHouse
25.12.3.21:SELECT metric FROM system.asynchronous_metrics WHERE metric = 'MarkCacheBytes'→ 0 rowsSELECT metric FROM system.metrics WHERE metric = 'MarkCacheBytes'→ 1 rowReview checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged