Skip to content

Add AI Guard client IP system test#6712

Open
smola wants to merge 2 commits intomainfrom
smola/ai-guard-ip-tags
Open

Add AI Guard client IP system test#6712
smola wants to merge 2 commits intomainfrom
smola/ai-guard-ip-tags

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Apr 9, 2026

Motivation

We want to collect http.client_ip and network.client.ip for HTTP requests that contain, at least, one AI Guard span.

APPSEC-62198

Changes

Add the relevant system test, as missing feature everywhere.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

CODEOWNERS have been resolved as:

docs/understand/scenarios/ai_guard.md                                   @DataDog/k9-ai-guard @DataDog/system-tests-core
manifests/cpp_httpd.yml                                                 @DataDog/dd-trace-cpp
manifests/cpp_nginx.yml                                                 @DataDog/dd-trace-cpp
manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
tests/ai_guard/test_ai_guard_sdk.py                                     @DataDog/k9-ai-guard @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core

@smola smola force-pushed the smola/ai-guard-ip-tags branch from be44f61 to 2db7af9 Compare April 9, 2026 14:13
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 bot commented Apr 9, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 20aad97 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@smola smola marked this pull request as ready for review April 10, 2026 13:34
@smola smola requested review from a team as code owners April 10, 2026 13:34
@smola smola requested review from ZStriker19, daniel-romano-DD, manuel-alvarez-alvarez, tabgok and vlad-scherbich and removed request for a team April 10, 2026 13:34
Copy link
Copy Markdown
Member

@y9v y9v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏼

It will be not so easy to implement for Ruby I'm afraid, but let's see if we can find some easy approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants