Skip to content

Only load what is actually going to be used by build v3 #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shangyian wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −5
Draft

Only load what is actually going to be used by build v3 #1844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions datajunction-server/datajunction_server/construction/build_v3/loaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,19 +392,41 @@ async def load_nodes(ctx: BuildContext) -> None:
),
joinedload(NodeRevision.catalog),
selectinload(NodeRevision.required_dimensions).options(
# Load the node_revision and node to reconstruct full dimension path
# Only need col.name to reconstruct full dimension path
load_only(Column.name),
joinedload(Column.node_revision).options(
noload(NodeRevision.created_by), # Prevent User N+1 queries
load_only(NodeRevision.name),
noload(NodeRevision.created_by),
joinedload(NodeRevision.node).options(
noload(Node.created_by), # Prevent User N+1 queries
load_only(Node.name),
noload(Node.created_by),
),
),
),
joinedload(NodeRevision.availability), # For materialization support
selectinload(NodeRevision.dimension_links).options(
# Load dimension node for link matching in temporal filters
# Restrict to fields actually used during query building
load_only(
DimensionLink.role,
DimensionLink.join_sql,
DimensionLink.join_type,
DimensionLink.join_cardinality,
DimensionLink.default_value,
DimensionLink.dimension_id,
DimensionLink.node_revision_id,
),
joinedload(DimensionLink.dimension).options(
noload(Node.created_by), # Prevent User N+1 queries
load_only(Node.name, Node.current_version),
noload(Node.created_by),
# Load dimension's current revision + columns for temporal partition
# support (measures.py accesses link.dimension.current.columns)
joinedload(Node.current).options(
load_only(NodeRevision.name),
noload(NodeRevision.created_by),
selectinload(NodeRevision.columns).options(
load_only(Column.name, Column.type),
),
),
),
),
),
Expand Down
Loading