Updated list of suppported platforms

[whatevergeek]

Trello Integration now works on both Android and Windows Platforms.

[coveralls]

Coverage remained the same at 88.372% when pulling 52b2797 on whatevergeek:patch-2 into e103840 on DataKind-SG:master.

[coveralls]

Coverage remained the same at 88.372% when pulling 1047b3a on whatevergeek:patch-2 into e103840 on DataKind-SG:master.

[oliverxchen]

In what's app, you mentioned that it works in windows only with the following change:
import sys, os myPath = os.path.dirname(os.path.abspath(_file_)) sys.path.insert(0, myPath + '/../')

What problem does this fix? The user root path for finding .tddc_config.yml? Or something else? Let's fix that before saying it works :)

[whatevergeek]

if we don't put that code in the test script...
it's unable to reference the clean_foobar_data
whether we run it in the main or immediate folder:
[image: Inline image 2]

feel free to let me know if you need further details :-)

On Mon, Sep 26, 2016 at 10:24 PM, oliverxchen notifications@github.com
wrote:

@oliverxchen requested changes on this pull request.

In what's app, you mentioned that it works in windows only with the
following change:
import sys, os
myPath = os.path.dirname(os.path.abspath(file))
sys.path.insert(0, myPath + '/../')

What problem does this fix? The user root path for finding
.tddc_config.yml? Or something else? Let's fix that before saying it
works :)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#50 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHAtg7ILegUq4OGSbYADsJM6cTnwF-iHks5qt9WEgaJpZM4KGXw3
.

[oliverxchen]

Ah, I think I understand now. I believe that issue was resolved in this PR: #43

Can you try to fetch upstream to get the newest version of master? If that works without your fix, then I'll merge this PR.

Thanks!

[whatevergeek]

yeah... it works now...

just noting these few observations:

1. I assume that PR output tests to same directory as main cleaning scripts #43 is not yet picked up by PyPi. I tried uninstalling/installing via pip but it's still using the old codebase. Hence, I used the latest build.py version from github. Once the file is updated , it works. Even skips the testing also. See above screenshot for result.
2. In Windows, pip doesn't add tddc to the path by default. Had to reference it directly.
   e.g.
   python D:\anaconda3\lib\site-packages\tddc\ summarize .\foobar_data.csv

Not sure if this matters. One can always add it to the path or wrap it in a powershell function like this:
function tddc { python D:\Anaconda3\Lib\site-packages\tddc\ $args}

feel free to let me know if any further actions needed. :-)

[oliverxchen]

Yep, I haven't published those changes to PyPI. You can see how far behind PyPI is (if at all) relative to the master branch here: https://github.com/DataKind-SG/test-driven-data-cleaning/releases

Looks good, but just a reminder that those 3 tests aren't the tests for the project, they're the generated tests for the sample data set. The tests for the project are here: https://github.com/DataKind-SG/test-driven-data-cleaning/tree/master/tddc/tests

There's a super simple bash script in the bin sub-directory that's part of the pip package: https://github.com/DataKind-SG/test-driven-data-cleaning/tree/master/bin. If we include the powershell equivalent, maybe it will work in windows without needing to directly reference?