Skip to content

Fix: incorrect ~1 decoding in decode_pointer_inplace #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CyberpsychoJacob wants to merge 2 commits into
base: master
Choose a base branch
from
+25 −1
Open

Fix: incorrect ~1 decoding in decode_pointer_inplace #1019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba03c7b
Fix incorrect ~1 decoding in decode_pointer_inplace
CyberpsychoJacob May 13, 2026
2fded40
Add unit test for ~1 JSON Pointer decode fix
CyberpsychoJacob May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cJSON_Utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ static void decode_pointer_inplace(unsigned char *string)
}
else if (string[1] == '1')
{
decoded_string[1] = '/';
decoded_string[0] = '/';
}
else
{
Expand Down
24 changes: 24 additions & 0 deletions tests/misc_utils_tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,29 @@
#include "common.h"
#include "../cJSON_Utils.h"

static void decode_pointer_inplace_should_decode_tilde_one_to_forward_slash(void)
{
/* A key whose name contains a literal '/' must be addressed in a JSON
* Pointer using the ~1 escape sequence (RFC 6901). A previous bug wrote
* '/' to decoded_string[1] instead of decoded_string[0], leaving '~' in
* place and producing "~/" instead of "/". */
cJSON *object = cJSON_Parse("{\"foo/bar\": 1}");
cJSON *patch = cJSON_Parse("[{\"op\": \"replace\", \"path\": \"/foo~1bar\", \"value\": 2}]");
cJSON *item = NULL;

TEST_ASSERT_NOT_NULL(object);
TEST_ASSERT_NOT_NULL(patch);

TEST_ASSERT_EQUAL_INT(0, cJSONUtils_ApplyPatches(object, patch));

item = cJSON_GetObjectItemCaseSensitive(object, "foo/bar");
TEST_ASSERT_NOT_NULL_MESSAGE(item, "Key \"foo/bar\" not found after patch with ~1 path.");
TEST_ASSERT_EQUAL_DOUBLE(2.0, item->valuedouble);

cJSON_Delete(object);
cJSON_Delete(patch);
}

static void cjson_utils_functions_shouldnt_crash_with_null_pointers(void)
{
cJSON *item = cJSON_CreateString("item");
Expand Down Expand Up @@ -74,6 +97,7 @@ int main(void)
{
UNITY_BEGIN();

RUN_TEST(decode_pointer_inplace_should_decode_tilde_one_to_forward_slash);
RUN_TEST(cjson_utils_functions_shouldnt_crash_with_null_pointers);

return UNITY_END();
Expand Down