Draft
Conversation
Member
|
Just a suggestion... You can add the |
Contributor
Author
SDL specifically undefines |
Lgt2x
requested changes
Jun 24, 2024
13 tasks
tophyr
force-pushed
the
android
branch
3 times, most recently
from
40bc996 to
142c739
Compare
tophyr
force-pushed
the
android
branch
2 times, most recently
from
bf7e6eb to
18169e5
Compare
tophyr
force-pushed
the
android
branch
3 times, most recently
from
a5dc732 to
3d4601e
Compare
13 tasks
Contributor
Author
|
@Lgt2x this is finally ready! The game builds, has a mechanism to easily (and legally) put gamedata on the device, and will start up a level. There's still a fair bit of work to do in order get the game playable, but at this point I think it's stable enough to start relying on build signals from GitHub CI. Do note that this now PR includes the |
Lgt2x
reviewed
Dec 30, 2024
tophyr
force-pushed
the
android
branch
5 times, most recently
from
5165157 to
fa99fa4
Compare
# Conflicts: # .github/workflows/build.yml # CMakeLists.txt # renderer/HardwareOpenGL.cpp # renderer/shaders/fragment.glsl
Using the ExternalProject module didn't give the simplicity I was hoping for, and caused other problems with the Android build, so moving away from it in favor of just presets and specifically-separate host and target builds. This reverts commit 0ef140d. # Conflicts: # .github/workflows/build.yml
Using the ExternalProject module didn't give the simplicity I was hoping for, and caused other problems with the Android build, so moving away from it in favor of just presets and specifically-separate host and target builds. In order to use HogMaker in cross-compile builds, configure and build the project for the host first (using `--target HogMaker` if you want to build just HogMaker) and then specify the HogMaker tool binary path with `-DHOGMAKER_PATH=`. This reverts commit 0ef140d. # Conflicts: # .github/workflows/build.yml
SDL EventFilters were *always* the incorrect way to handle input, but now in SDL3 are even more incorrect as they run on the thread that accepts the input, not the thread that's intended to handle it. (This is a significant difference on Android and iOS.) The fix is surprisingly simple: Just poll for input in the OS defer handler. This is already called at the start of every type of every frame, so it is the perfect place to grab input.
We're going to start handling SDL touch events ourselves, so we don't want fake mouse events getting in the way.
Process and track touchscreen events.
Text entry on Android and iOS devices is accomplished by displaying an "Input Method Editor", or IME (soft keyboard), over the running application. The UI model is such that the application is supposed to adjust its graphical layout so that the text-entry field is repositioned to fit above the newly-displayed keyboard. This change adds support for discovering what the IME's insets are, and adjusting the top-level window to be displayed within the area not covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Adds Android as a supported platform. Uses Gradle to perform the build overall.
Checklist