Fix VC Code and Zed install paths on Windows#153
Open
jimpark wants to merge 1 commit intoDeusData:mainfrom
Open
Fix VC Code and Zed install paths on Windows#153jimpark wants to merge 1 commit intoDeusData:mainfrom
jimpark wants to merge 1 commit intoDeusData:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing Zed and VS Code detection/install/remove code used home_dir + "/.config/..." paths, which is Linux-specific.
On macOS it already had #ifdef APPLE with the Library/Application Support/ path, but there was no Windows case, and
the Linux fallback was hardcoded rather than respecting XDG_CONFIG_HOME.
What changed:
Two new platform helpers (cbm_app_config_dir(), cbm_app_local_dir()) return the OS-appropriate config directory:
Zed — 3 locations (detect, install, remove) now use:
VS Code — 3 locations (detect, install, remove) now use:
Net effect: No behavior change on macOS or Linux (paths resolve identically). On Windows, Zed and VS Code config
directories are now found correctly instead of looking under the nonexistent ~/.config/ path.