fix: isFlushingEvents flag can get stuck true if publishEvents throws#193
Open
jonathannorris wants to merge 2 commits intomainfrom
Open
fix: isFlushingEvents flag can get stuck true if publishEvents throws#193jonathannorris wants to merge 2 commits intomainfrom
jonathannorris wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures the local event flushing logic can’t get permanently “locked” by resetting isFlushingEvents via try/finally even when publishEvents() throws, preventing future flushEvents() calls from returning early and leaving events unsent.
Changes:
- Wraps the event publish loop in
flushEvents()in atry/finally. - Guarantees
isFlushingEventsis always reset tofalseafter a flush attempt, even on exception.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
suthar26
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the publish loop in a
try/finallysoisFlushingEventsis always reset tofalse, even ifpublishEvents()throwsInterruptedException.Without this, any exception escaping the loop leaves the flag permanently
trueand all subsequentflushEvents()calls return early, causing events to accumulate and never be sent.Fixes #192