CardView: Fix cards not updating on column visibility/order changes (T1324855)#33011
Merged
Alyar666 merged 8 commits intoDevExpress:26_1from Mar 27, 2026
Merged
CardView: Fix cards not updating on column visibility/order changes (T1324855)#33011Alyar666 merged 8 commits intoDevExpress:26_1from
Alyar666 merged 8 commits intoDevExpress:26_1from
Conversation
…24855) - Add visibleColumnsLayout computed to track column identity/order changes without subscribing to sort/filter metadata updates - Read visibleColumns via untracked() to avoid extra re-renders - Add e2e tests for column chooser (select & dragAndDrop modes) and reordering - Extract getCardFieldCaptions helper to shared cardUtils
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CardView cards not updating when visible columns are reordered or toggled via the column chooser by ensuring the ItemsController.items computed is invalidated on visible column layout changes, and adds E2E coverage for the regression (T1324855).
Changes:
- Add a computed “visible columns layout” signature and use it to trigger card re-creation on visible column order/visibility changes.
- Add shared TestCafe helper to read card field captions.
- Add E2E tests covering card updates on column reorder and column chooser hide/show (select + dragAndDrop).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/new/grid_core/items_controller/items_controller.ts | Forces items recomputation when the visible columns layout changes (order/visibility). |
| e2e/testcafe-devextreme/tests/cardView/helpers/cardUtils.ts | Adds helper to extract card field captions for assertions. |
| e2e/testcafe-devextreme/tests/cardView/columnSortable/functional.ts | Adds E2E test verifying cards update after column reordering. |
| e2e/testcafe-devextreme/tests/cardView/columnChooser/functional.ts | Adds E2E tests verifying cards update when hiding/showing columns via chooser. |
packages/devextreme/js/__internal/grids/new/grid_core/items_controller/items_controller.ts
Outdated
Show resolved
Hide resolved
added 2 commits
March 23, 2026 15:06
…tems computed - Replace name-only layout key with exclusion-based approach: only sortOrder, sortIndex, filterValues, filterType are excluded from the column layout key (they trigger data reload separately) - Any new column property automatically triggers items recalculation - Add unit tests for caption, format, alignment reactivity
packages/devextreme/js/__internal/grids/new/grid_core/items_controller/items_controller.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/grid_core/items_controller/items_controller.ts
Outdated
Show resolved
Hide resolved
Raushen
reviewed
Mar 23, 2026
| cardIndex = 0, | ||
| ): Promise<string[]> => { | ||
| const card = cardView.getCard(cardIndex); | ||
| const captionElements = card.element.find(FIELD_CAPTION_SELECTOR); |
Contributor
There was a problem hiding this comment.
We need card.getCaptions method
dmirgaev
reviewed
Mar 24, 2026
Comment on lines
+13
to
+15
| // NOTE: Column properties that do NOT affect card rendering. | ||
| // Changes to these properties trigger data reload via dataController.items, | ||
| // so subscribing to them in visibleColumns causes extra re-renders (T1306983, T1309423). |
Contributor
There was a problem hiding this comment.
I don't understand this comment: these properties do NOT affect rendering, but cause extra re-renders while being changed, right? It sounds a bit contradictory
dmirgaev
reviewed
Mar 24, 2026
packages/devextreme/js/__internal/grids/new/grid_core/items_controller/items_controller.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/grid_core/items_controller/utils.ts
Show resolved
Hide resolved
dmirgaev
previously approved these changes
Mar 25, 2026
Raushen
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.