Chat: Move init of errors into component level (T1325479)#33071
Merged
marker-dao merged 2 commits intoDevExpress:26_1from Mar 27, 2026
Merged
Chat: Move init of errors into component level (T1325479)#33071marker-dao merged 2 commits intoDevExpress:26_1from
marker-dao merged 2 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the internal ChatTextArea implementation so the “file limit reached” warning text is formatted at the time it’s needed (component-level), allowing runtime localization updates to be reflected correctly.
Changes:
- Replace a pre-formatted, module-level “file limit reached” error string with a runtime
messageLocalization.format(...)call. - Introduce tests verifying that a custom localization message is respected when loaded both before and after component initialization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/chatTextArea.tests.js | Adds localization-focused coverage for the informer message when file limit is reached. |
| packages/devextreme/js/__internal/ui/chat/message_box/chat_text_area.ts | Moves localization formatting for the file-limit warning into the event handler to avoid stale, precomputed messages. |
packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/chatTextArea.tests.js
Outdated
Show resolved
Hide resolved
r-farkhutdinov
approved these changes
Mar 27, 2026
marker-dao
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.