Security: Unbounded async queue key growth can cause memory exhaustion#8506
Open
tuanaiseo wants to merge 1 commit intoDevExpress:masterfrom
Open
Conversation
`actions` stores promises by arbitrary `key` and never deletes completed entries. Repeated unique keys (especially attacker-controlled) can grow memory indefinitely, enabling a denial-of-service condition in long-lived processes. Affected files: async-queue.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
testcafe-need-response-bot
bot
added
the
STATE: Need response
tuanaiseo
requested a deployment
to
authentication
GitHub Actions
Waiting
Bayheck
added
STATE: PR Review Pending
|
Thank you for your contribution to TestCafe. When a member of the TestCafe team becomes available, they will review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
actionsstores promises by arbitrarykeyand never deletes completed entries. Repeated unique keys (especially attacker-controlled) can grow memory indefinitely, enabling a denial-of-service condition in long-lived processes.Severity:
mediumFile:
src/utils/async-queue.jsSolution
Remove queue entries after completion (
finallycleanup), enforce key limits, and avoid accepting untrusted high-cardinality keys directly.Changes
src/utils/async-queue.js(modified)Testing