Skip to content

[codex] Use workflow token for dev GHCR pull #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jjoonleo wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −6
Draft

[codex] Use workflow token for dev GHCR pull #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ jobs:
FIREBASE_CREDENTIALS_BASE64=${{ secrets.DEV_FIREBASE_CREDENTIALS_BASE64 }}
EOF

echo "${{ secrets.GHCR_READ_TOKEN }}" | sudo docker login ghcr.io -u "${{ secrets.GHCR_USERNAME }}" --password-stdin
echo "${{ secrets.GITHUB_TOKEN }}" | sudo docker login ghcr.io -u "${{ github.actor }}" --password-stdin

if sudo docker compose version >/dev/null 2>&1; then
COMPOSE="sudo docker compose"
Expand Down
4 changes: 2 additions & 2 deletions docs/deployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ Required development secrets:
- `DEV_REMOTE_HOST`
- `DEV_REMOTE_USER`
- `DEV_REMOTE_SSH_KEY`
- `GHCR_USERNAME`
- `GHCR_READ_TOKEN`

The development workflow uses the run-scoped `GITHUB_TOKEN` to pull the image from GHCR on the remote PC, so no long-lived GHCR read token is required for development deploys.

Optional development secrets:

Expand Down
4 changes: 1 addition & 3 deletions docs/git-workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,9 @@ Development deploy should use development secrets only:
DEV_REMOTE_HOST
DEV_REMOTE_USER
DEV_REMOTE_SSH_KEY
GHCR_USERNAME
GHCR_READ_TOKEN
```

Optional `DEV_*` secrets can override the default dev deploy directory, HTTP port, MySQL credentials, and non-production OAuth/Firebase settings.
The development deploy uses the workflow `GITHUB_TOKEN` for GHCR image pulls. Optional `DEV_*` secrets can override the default dev deploy directory, HTTP port, MySQL credentials, and non-production OAuth/Firebase settings.

## Branch Protection

Expand Down
Loading