Skip to content

Preserve nested evidence paths instead of collapsing names (merges into #96)#98

Merged
DevOpsMadDog merged 1 commit into
codex/implement-parser-hardening-and-safety-improvementsfrom
cubic-fix-fixops-utils-paths-py-L12-1760531107
Oct 17, 2025
Merged

Preserve nested evidence paths instead of collapsing names (merges into #96)#98
DevOpsMadDog merged 1 commit into
codex/implement-parser-hardening-and-safety-improvementsfrom
cubic-fix-fixops-utils-paths-py-L12-1760531107

Conversation

@cubic-dev-ai
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot commented Oct 15, 2025

🤖 PR by cubic

This PR addresses the comment in #96 – Harden parser validation and evidence guardrails

File: fixops/utils/paths.py
Line: 12
Comment:

Using Path(...).name collapses every input to a single filename, so callers specifying nested evidence paths (e.g., "reports/logs/event.json") will now write to the root as "event.json" and lose directory structure. This breaks valid usages without improving safety; the existing resolve/parent check already blocks escapes.

This fix was automatically generated. Please review the changes carefully before merging.


Summary by cubic

Preserves nested evidence paths in resolve_within_root so directories like "reports/logs/event.json" are kept instead of being collapsed to "event.json". Root containment is still enforced through path resolution and parent checks.

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@DevOpsMadDog DevOpsMadDog merged commit 3f8b038 into codex/implement-parser-hardening-and-safety-improvements Oct 17, 2025
2 of 6 checks passed
DevOpsMadDog added a commit that referenced this pull request May 6, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant