test(agent): e2e + registry + routing test suite#1772
Draft
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Draft
test(agent): e2e + registry + routing test suite#1772irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Conversation
irvingouj@Devolutions (irvingoujAtDevolution)
marked this pull request as draft
irvingouj@Devolutions (irvingoujAtDevolution)
changed the title
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/quic-tunnel-2-routing
branch
2 times, most recently
from
b4ec360 to
a2b2ff5
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
added a commit
that referenced
this pull request
May 12, 2026
Address CBenoit's review on #1741: in addition to the `#[doc(hidden)]` marker and the `_for_test` naming, gate `AgentPeer::set_last_seen_for_test` and `set_received_at_for_test` behind `#[cfg(any(test, feature = "test-utils"))]` so production builds of `devolutions-gateway` and `devolutions-agent` don't compile these methods at all. Cross-crate test consumers (the workspace `testsuite` crate carrying the agent-tunnel integration tests, in #1772) opt in via `features = ["test-utils"]` on their `agent-tunnel` dev-dep.
- testsuite/tests/agent_tunnel/integration.rs: full QUIC e2e (CA → enroll → mTLS → control stream → ConnectRequest → echo) and a domain-routing variant. - testsuite/tests/agent_tunnel/registry.rs: AgentRegistry unit tests covering online/offline timeouts, route epoch handling (replace vs refresh vs ignore stale), domain advertisement persistence, and the agent-info snapshot. - testsuite/tests/agent_tunnel/routing.rs: RoutePlan::resolve / try_route decision matrix — explicit jet_agent_id, subnet match, domain match, fallback to direct, offline filtering, and the no-handle paths. Also includes the read_cert_chain rewrite from #1771 (needed for the e2e tests to parse the rcgen-produced PEM); once #1771 lands this collapses to just the test files.
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/agent-tunnel-tests
branch
from
552f7da to
e5256ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the agent-tunnel test suite under
testsuite/tests/agent_tunnel/:integration.rs— full QUIC end-to-end (CA → enroll → mTLS → control stream → ConnectRequest → echo) plus the domain-routing variantregistry.rs—AgentRegistryunit tests (online/offline timeouts, route epoch handling, domain advertisement persistence, agent-info snapshot)routing.rs—RoutePlan::resolve/try_routedecision matrix (explicitjet_agent_id, subnet/domain match, fallback, offline filtering, no-handle paths)Why split out
PR #1741 (the routing/upstream feature) keeps its diff focused on production code. Tests live here so a 924-line test scaffolding diff doesn't muddle the feature review.
Stack
feat/quic-tunnel-2-routing(feat(agent): transparent routing through agent tunnel #1741)read_cert_chainrewrite — the e2e tests rely on the rcgen-produced PEM parsing correctly). The cert.rs change is included in this branch as a single commit alongside the tests; once refactor(agent): rewrite read_cert_chain with picky read_pem #1771 lands, this rebases cleanly to just the test files.Test plan
cargo test -p testsuite --test integration_tests agent_tunnel::— 25/25 pass locally