feat: check of server and client version in response header#1443
Open
shree-iyengar-dls wants to merge 7 commits intomainfrom
Open
feat: check of server and client version in response header#1443shree-iyengar-dls wants to merge 7 commits intomainfrom
shree-iyengar-dls wants to merge 7 commits intomainfrom
Conversation
shree-iyengar-dls
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
==========================================
+ Coverage 95.19% 95.20% +0.01%
==========================================
Files 43 43
Lines 3119 3129 +10
==========================================
+ Hits 2969 2979 +10
Misses 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ZohebShaikh
reviewed
Mar 18, 2026
| from fastapi.testclient import TestClient | ||
|
|
||
| from blueapi.service.main import get_passthrough_headers, log_request_details | ||
| import blueapi |
Contributor
There was a problem hiding this comment.
Suggested change
| import blueapi | |
| from blueapi import __version__ |
| LOGGER.warning( | ||
| f"Server version is {Version(server_version).release} and " | ||
| f"client version is {Version(__version__).release}" | ||
| ) |
Contributor
There was a problem hiding this comment.
I wrote this as a draft.
It can be some thing like
"Version mismatch: server is , client is {Version(version).release}"
Suggested change
| ) | |
| if (server_version := Version(server_version).release) != (client_version:= Version(__version__).release): | |
| LOGGER.warning( | |
| f"Version mismatch : Blueapi server version is {server_version}" | |
| f" and client version is {client_version}.Some features may not work as expected." | |
| ) |
Comment on lines
36
to
+38
|
|
||
| import blueapi | ||
| import blueapi.cli |
Contributor
There was a problem hiding this comment.
Suggested change
| import blueapi | |
| import blueapi.cli | |
| from blueapi import __version__ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1074
Check of version headers in the response has been added to the client side.