Skip to content

Changes to classification parameters for doppio#253

Merged
stephen-riggs merged 5 commits intomainfrom
class-live-params
Apr 15, 2026
Merged

Changes to classification parameters for doppio#253
stephen-riggs merged 5 commits intomainfrom
class-live-params

Conversation

@stephen-riggs
Copy link
Copy Markdown
Contributor

@stephen-riggs stephen-riggs commented Mar 23, 2026

  • make picker id optional and remove from recipes as murfey will no longer send it
  • change default mpi command. srun is used for this at Diamond, but is not the correct choice unless running on slurm. Switched to mpirun for the murfey (doppio-live) recipes but left as srun for the ispyb (DLS) recipes

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.10%. Comparing base (93f3199) to head (eb98810).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   83.68%   84.10%   +0.41%     
==========================================
  Files          68       69       +1     
  Lines        8619     9403     +784     
  Branches     1162     1392     +230     
==========================================
+ Hits         7213     7908     +695     
- Misses        966     1045      +79     
- Partials      440      450      +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephen-riggs stephen-riggs requested a review from tieneupin April 15, 2026 08:37
Comment thread src/cryoemservices/wrappers/refine3d_wrapper.py
Copy link
Copy Markdown
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I just have a question about why the switch was made from srun to mpirun when there used to be a key mpi_run_command that would run srun.

@stephen-riggs stephen-riggs merged commit 4e0a204 into main Apr 15, 2026
12 checks passed
@stephen-riggs stephen-riggs deleted the class-live-params branch April 15, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants