Skip to content

Added second panda interface for P51 beamline #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
subughimire420 merged 2 commits into from
Mar 24, 2026
Merged

Added second panda interface for P51 beamline #1986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b0d1ed
added second panda
subughimire420 Mar 23, 2026
d9bfe8c
Merge branch 'main' into inter-panda-triggering
subughimire420 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/dodal/beamlines/p51.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,21 @@ def turbo_slit_pmac(turbo_slit_x: Motor) -> PmacIO:


@devices.factory()
def panda(path_provider: PathProvider) -> HDFPanda:
def panda1(path_provider: PathProvider) -> HDFPanda:
return HDFPanda(
f"{PREFIX.beamline_prefix}-EA-PANDA-02:",
path_provider=path_provider,
)
Comment on lines +66 to 70
Copy link
Copy Markdown
Contributor

@oliwenmandiamond oliwenmandiamond Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panda1 device but PV is panda 2, is this correct?

Copy link
Copy Markdown
Contributor Author

@subughimire420 subughimire420 Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we designed the scans in panda-02 first, and called it panda1. That might be changed later, but as the scans currently stand, this is intentional and correct.



@devices.factory()
def panda2(path_provider: PathProvider) -> HDFPanda:
return HDFPanda(
f"{PREFIX.beamline_prefix}-EA-PANDA-01:",
path_provider=path_provider,
)
Comment on lines +74 to +78
Copy link
Copy Markdown
Contributor

@oliwenmandiamond oliwenmandiamond Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panda2 device but PV is panda 1, is this correct?



# Use mock device until motors are reconnected on the beamline
@devices.factory(mock=True)
def alignment_x() -> Motor:
Expand Down
Loading