Skip to content

Add open signal to FastShutter#1987

Merged
oliwenmandiamond merged 7 commits intomainfrom
Add_open_signal_to_fastshutters
Mar 24, 2026
Merged

Add open signal to FastShutter#1987
oliwenmandiamond merged 7 commits intomainfrom
Add_open_signal_to_fastshutters

Conversation

@oliwenmandiamond
Copy link
Contributor

Fixes #1985

Instructions to reviewer on how to test:

  1. Check implementation make sense
  2. Check tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner March 23, 2026 16:00
@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (a039d73) to head (05bd592).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1987   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         319      319           
  Lines       12267    12279   +12     
=======================================
+ Hits        12158    12170   +12     
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@oliwenmandiamond oliwenmandiamond merged commit 789df0a into main Mar 24, 2026
10 checks passed
@oliwenmandiamond oliwenmandiamond deleted the Add_open_signal_to_fastshutters branch March 24, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GenericFastShutter doesn't support generic syntax with BlueAPI

2 participants