Restructure OAV device organisation and naming (Artemis554)#25
Conversation
but keep derivative devices named snapshot
- move mjpg and mxsc to areadetector plugins - separate out oav utils - update i03
|
Can you make the PR title a bit more descriptive, dodal will use it for release note generation so should probably use something that makes sense to general DLS devs |
d-perl
changed the title
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Changes here look mostly good. Most comments are on Artemis PR. Do we still want the component in the OAV to be called snapshot, after renaming it to MJPG?
| input_plugin_pv: EpicsSignal = Component(EpicsSignal, "NDArrayPort") | ||
| enable_callbacks_pv: EpicsSignal = Component(EpicsSignal, "EnableCallbacks") | ||
| min_callback_time_pv: EpicsSignal = Component(EpicsSignal, "MinCallbackTime") | ||
| blocking_callbacks_pv: EpicsSignal = Component(EpicsSignal, "BlockingCallbacks") |
There was a problem hiding this comment.
Could: I think the word PV is a bit redundant here. We know they're all PVs
|
I left is as |
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 83.77% 84.79% +1.01%
==========================================
Files 51 52 +1
Lines 1609 1644 +35
==========================================
+ Hits 1348 1394 +46
+ Misses 261 250 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, mostly looks good, couple of questions in code
src/dodal/devices/oav/snapshot.py
Outdated
| @@ -13,7 +13,7 @@ class Snapshot(Device): | |||
| x_size_pv: EpicsSignalRO = Component(EpicsSignalRO, "ArraySize1_RBV") | |||
There was a problem hiding this comment.
Should: We can remove this file entirely now in favour of MJPG, correct?
2 participants
Goes with changes in DiamondLightSource/hyperion#584