Use daq config server for UndulatorDCM config#1497
Conversation
c4613e8 to
7c21294
Compare
7c21294 to
0ec62f4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
==========================================
- Coverage 92.88% 92.87% -0.01%
==========================================
Files 155 155
Lines 8498 8492 -6
==========================================
- Hits 7893 7887 -6
Misses 605 605
🚀 New features to boost your workflow:
|
rtuck99
left a comment
There was a problem hiding this comment.
Looks fine to me, however would be nice to see some minimal system tests with the config server so that we can verify we can read configs. I think also that having such tests also does help with thinking about endpoint configuration.
a66a068 to
c887f44
Compare
b4a55b8 to
33f5b44
Compare
| @@ -8,8 +8,7 @@ | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
could consider renaming the file here to config_client
| d_spacing_a: float = yield from bps.rd( | ||
| undulator_dcm.dcm_ref().crystal_metadata_d_spacing_a | ||
| ) | ||
| config_client = get_config_client("i03") |
There was a problem hiding this comment.
I think echoing what other people have said elsewhere, we should be able to locate the config client without having to specify the beamline. At a device level we could inject the config client via a fixture with the correct endpoint and not need to know the specific beamline or have get_config_client(), at least in devices experiment plans, we may need something to retrieve the correct client in a plan occasionally, but the plan shouldn't need to know which beamline it's on, only the type of resource it needs.
rtuck99
left a comment
There was a problem hiding this comment.
Approved, just need changes in the dodal PR as discussed
Fixes #1494
Link to dodal PR (if required): DiamondLightSource/dodal#1768
Also requires https://gitlab.diamond.ac.uk/MX-GDA/hyperion-system-testing/-/merge_requests/7
Reads
UndulatorDCMconfig through the config server.Also adds system tests and changes existing system tests to use a locally deployed real config server rather than mocking the client as is done in unit tests.
Instructions to reviewer on how to test:
Checks for reviewer