Draft
Conversation
DominicOram
requested changes
Mar 2, 2026
Contributor
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, some comments
| if (omega_start := doc.get("gonio-omega")) is not None: | ||
| omega_in_gda_space = -omega_start | ||
| if ( | ||
| omega_offset_and_phase := doc.get("gonio-omega_axis-offset_and_phase") |
Contributor
There was a problem hiding this comment.
Should: Why can't we just read gonio-omega_axis-phase here?
| else direction.NEGATIVE | ||
| ) | ||
|
|
||
| start_scan_deg = reference_angle.nearest_to_phase(start_scan_deg).unwrap() |
Contributor
There was a problem hiding this comment.
Should: The reference angle is presumably needed because the zebra is still in the old co-ordinate system? Did you think about setting the position on the zebra so that it is in the new co-ordinate system, see attached:
I think this will get us more on the way to the underlying motor behaviour being invisible at the plan level.
|
Please add a label to this PR. This helps with generating helpful release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Requires
Implements robot load at mod-360 values of omega and subsequent operations using the phase-angle of the omega axis rather than absolute values.
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Instructions to reviewer on how to test:
Checks for reviewer