Bugfix: AnalogInput handling#1
Open
guirodrigueslima wants to merge 1 commit intoDiamondLightSource:masterfrom
Open
Bugfix: AnalogInput handling#1guirodrigueslima wants to merge 1 commit intoDiamondLightSource:masterfrom
guirodrigueslima wants to merge 1 commit intoDiamondLightSource:masterfrom
Conversation
The initialization logic for AnalogInputInterval and AnalogInputEnable has been updated. At Sirius, some e-Vision 2 units do not provide analog input/output capabilities. In these cases, the AnalogInputInfo command returns only a header with no valid data. Attempting to configure AnalogInputInterval and AnalogInputEnable results in an error, causing the IOC initialization to fail. To address this issue, the IOC now checks the number of available analog inputs using the Info command response. Analog input configuration is only performed when inputs are present. This change ensures compatibility with different e-Vision 2 variants and does not affect existing behavior for systems that support analog inputs, such as Microvision modules.
Contributor
|
thanks @guirodrigueslima its not going to be easy to test this change for a while. But I will do so when I containerise this module somethime in the next 12 months and will merge your change then if it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initialization logic for AnalogInputInterval and AnalogInputEnable has been updated. At Sirius in Brazil, some e-Vision 2 units do not provide analog input/output capabilities. In these cases, the AnalogInputInfo command returns only a header with no valid data. Attempting to configure AnalogInputInterval and AnalogInputEnable results in an error, causing the IOC initialization to fail.
To address this issue, the IOC now checks the number of available analog inputs using the Info command response. Analog input configuration is only performed when inputs are present.
This change ensures compatibility with different e-Vision 2 variants and does not affect existing behavior for systems that support analog inputs, such as Microvision modules.